test.js in root no longer works with v6.0.0

[puzrin]

Prerequisites

• Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
• Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
• 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
• Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha.

Description

v6.0.0 seems not work for small projects without test/ folder and with test.js in root instead/

Steps to Reproduce

• project: https://github.com/markdown-it/uc.micro
• greenkeeper PR and Travis-CI log: Update mocha to the latest version 🚀 markdown-it/uc.micro#11

Expected behavior: [What you expect to happen]

Everything should work as before

Actual behavior: [What actually happens]

$ npm test
> uc.micro@1.0.6 test /home/travis/build/markdown-it/uc.micro
> mocha
Error: No test files found: "test/"
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

• The output of mocha --version and node node_modules/.bin/mocha --version: 6.0.0
• The output of node --version: v10.11.0
• The version and architecture of your operating system: Ubuntu 18.04
• Your shell (bash, zsh, PowerShell, cmd, etc.): bash
• Your browser and version (if running browser tests):
• Any other third party Mocha related modules (with versions):
• The code transpiler being used:

Additional Information

I could not find any info that such feature was deprecated. Let me know if i missed something.

[plroebuck]

Could you provide your "package.json" scripts.test for reference?

[puzrin]

https://github.com/markdown-it/uc.micro/blob/master/package.json

{ "test": "mocha" }

[plroebuck]

Honestly, it's been documented as being './test/*.js' since the beginning of time... well,
Nov 17, 2011 anyway in commit 9347629.

Having worked in this area of the code, I know utils.lookupFiles checks the glob for existence (as a file) and if not, appends ".js" and rechecks. This (unintended?) implementation detail would have allowed your "test.js" file to satisfy a glob passed as just "test".

Have seen many small packages with a "test.js" file, but had never considered this file as providing a default specification for running mocha without arguments.

You don't mention the previous mocha version you were running where this last worked... 5.2.0?

[puzrin]

You don't mention the previous mocha version you were running where this last worked... 5.2.0?

Yes.

I don't insist. If you will recommend move files into /test/ - i will do. Just wish to understand first, what's happened and "official opinion".

[plroebuck]

Confirmed that Mocha-5.2 uses "test" as its glob.
Likely cause in Mocha-6.0 is here; changing the value to "test" should restore the previous behavior.

@puzrin, got time to patch your install (delete that trailing backslash) and see?
If that indeed does the trick, I'll submit the patch today.

[boneskull]

@plroebuck good catch. would like to get a v6.0.1 out today if possible.

[puzrin]

Tested. After remove / in

mocha/lib/cli/run.js

Line 248 in 42303e2

default: ['test/'],

, as suggested by @plroebuck , everything works again.