Skip to content

Conversation

@adshmh
Copy link
Contributor

@adshmh adshmh commented Sep 19, 2018

Remove the redundant integration test TestExportContainerWithOutputAndImportImage

This test is the same as TestExportContainerAndImportImage, except for the output file option.
A unit test has been added to docker/cli to cover the output file option: docker/cli#1377. Therefore this test can be removed.

Signed-off-by: Arash Deshmeh [email protected]

- What I did
Removed the redundant integration test TestExportContainerWithOutputAndImportImage

- How I did it
Deleted the test file integration-cli/docker_cli_export_import_test.go

- How to verify it

- Description for the changelog
Removed the redundant integration test TestExportContainerWithOutputAndImportImage

- A picture of a cute animal (not mandatory but encouraged)

…dImportImage

This test is the same as TestExportContainerAndImportImage, except for the output file option.
A unit test has been added to docker/cli to cover the output file option. Therefore this test can be removed.

Signed-off-by: Arash Deshmeh <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9c65b22). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37885   +/-   ##
=========================================
  Coverage          ?   36.12%           
=========================================
  Files             ?      610           
  Lines             ?    45083           
  Branches          ?        0           
=========================================
  Hits              ?    16288           
  Misses            ?    26555           
  Partials          ?     2240

@vdemeester vdemeester merged commit 5d848e6 into moby:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants