add a unit test to cover container export command output file option #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om moby/moby to docker/cli. The integration test TestExportContainerWithOutputAndImportImage in moby/moby is the same as TestExportContainerAndImportImage, except for the output file option. Adding a unit test to cover the output file option of the export command here allows the removal of the redundant integration test TestExportContainerWithOutputAndImportImage. Signed-off-by: Arash Deshmeh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
+ Coverage 54.79% 54.88% +0.09%
==========================================
Files 293 293
Lines 19428 19428
==========================================
+ Hits 10645 10663 +18
+ Misses 8110 8089 -21
- Partials 673 676 +3 |
Contributor
Author
|
If this PR gets approved, I can submit a PR on moby to remove the redundant integration test. |
lifubang
pushed a commit
to lifubang/cli
that referenced
this pull request
Oct 15, 2018
…rWithOutputAndImportImage-from-moby add a unit test to cover container export command output file option Signed-off-by: Lifubang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a unit test to cover the output file option of the
exportcommand. If merged, this allows the removal of the redundant integration testTestExportContainerWithOutputAndImportImagefrommoby, which is the same asTestExportContainerAndImportImage, except for the output file option:https://github.com/moby/moby/blob/d6a7c22f7b9aa028623ef8c7cb31d1bb04dd9d84/integration-cli/docker_cli_export_import_test.go#L12-L17
Signed-off-by: Arash Deshmeh [email protected]
- What I did
Added a unit test to cover the output file option of the
exportcommand- How I did it
Added new test file
cli/command/container/export_test.go- How to verify it
- Description for the changelog
Added unit test for output to file option of the export command.
- A picture of a cute animal (not mandatory but encouraged)