Update GCP icons #666
Update GCP icons #666
Conversation
|
@mingrammer FYI this should be an easy PR and merge. There are no breaking changes; I only updated the existing GCP icons. Thanks in advance for the review! |
|
Hey @mingrammer i was wondering if you were able to review the PR yet? Thanks in advance!!! |
|
hey @mingrammer whenever you get free time again, feel free to approve this PR first 😄 😉 . However, please note, I'm biased 🤣 |
|
hey @mingrammer just curious if you had a chance to review this PR yet. thanks in advance! |
|
hey @mingrammer sorry to bother you again, but I finally moved states and am trying to get back to finishing my existing work. I believe this PR is still good to go, just needs your final review (and maybe approval 😄 ). Thanks in advance. |
|
hey @mingrammer sorry to keep pinging you, just trying to bump this so it doesn't get out of sync too much. Hope all is well <3 |
|
@DataDavD Sorry for the tooo late reply. I'll review it ASAP. Sorry again :(. |
mingrammer
left a comment
mingrammer
left a comment
There was a problem hiding this comment.
Thank you for your efforts. Love it.
I have a request, could you please update the example diagrams on the README and website page?
|
And you should resolve the conflicts. |
|
Thanks @MinGramme!!!! I'll work on these updates over the weekend and push out the updates to this PR early next week. |
codeaucafe
force-pushed
the
ddansby/Issue-554/update-existing-GCP-icons
branch
from
400064a to
e0a3245
Compare
|
hey @mingrammer I resolved the conflicts, and am looking into updating the GCP icon usages on readme and website right now. Should have it complete before mid-week. Thanks again. |
Update existing GCP icons using updated official GCP icons: see https://cloud.google.com/icons. This includes changes to GCP nodes and examples shown on the website. Note, generic icons are updated with the corresponding new generic icon, except "ai-platform-data-labeling-service.png" since it now has its own unique icon. Closes mingrammer#554. refactor
codeaucafe
force-pushed
the
ddansby/Issue-554/update-existing-GCP-icons
branch
from
e0a3245 to
ed39a75
Compare
|
@mingrammer FYI I have updated the website and readme pages accordingly. I think everything should be good now. I can't wait to get this out to the community. Thanks in advance. Best, |
|
Hey @mingrammer just bumping this again. I believe everything is good now. Let me know if I need to add or tweak anything else. Thank you! |
|
@DataDavD Thank you very much!! |
|
Awesome thank you so much @mingrammer !!! |
Update existing GCP icons using updated official GCP icons: see https://cloud.google.com/icons. This includes changes to GCP nodes and examples shown on the website. Note, generic icons are updated with the corresponding new generic icon, except "ai-platform-data-labeling-service.png" since it now has its own unique icon. Closes mingrammer#554. refactor
Update existing GCP icons using updated official GCP icons: see https://cloud.google.com/icons. This includes changes to GCP nodes and examples shown on the website. Note, generic icons are updated with the corresponding new generic icon, except "ai-platform-data-labeling-service.png" since it now has its own unique icon. Closes mingrammer#554. refactor
2 participants
Update existing GCP icons using updated official GCP icons:
see https://cloud.google.com/icons.
Note, generic icons are updated with the corresponding new generic icon,
except "ai-platform-data-labeling-service.png" since it now has its
own unique icon.
Closes #554.