Update GCP Icons

[soomineom]

Hi there,
I'm enjoying using Diagrams.

But I've noticed a lot of the GCP icons appear to be outdated...

There is a new GCP architecture icons pack available at this link: https://cloud.google.com/icons
Is it possible to update the library to use these?

Thanks,
Soomin

[gabriel-tessier]

@soomineom

Thanks for the link, if you feel comfortable with the contributions guide you can make a PR.

https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

Or I can start checking about later this week.

[codeaucafe]

hey @soomineom and @gabriel-tessier if y'all need help I'd be more than happy to assist in updating any icons for GCP or other cloud providers. Just let me know. I'll wait for soonmineom to confirm before starting though.

I can take a look at other providers and see if they need updating too in mean time.

Happy coding

[soomineom]

@DataDavD Hi ,
I will really appreciate if u help me to update icons for GCP !

Thank you

[codeaucafe]

Alright, sounds good! I should be able to get started/finish by end of this week🤞. I'll submit a PR or ask another question here if I have one.

cc @gabriel-tessier @soomineom .
Thank you!!

dd

[mingrammer]

Thank you guys :)

[codeaucafe]

So, I took a look at the updated icons and I just wanna clarify that these updated ones appear to have removed the blue hexagon-shaped background for all the icons. Do you all think that is a particularly good idea for using those in diagrams?

TL;DR: when updating diagrams what determines whether or not we should update? Is the purpose of this project to always use the most updated icons or those that look particular the best when used in complex diagrams. I ask because it seems like Draw.io is still using the icons with the blue hexagon-shaped background, but maybe they just take longer to update. I just wanna be clear what's best to use before working to add these.

For reference I was referring to the .png file found in the SVG and PNG Icons set here. Thanks in advance for helping to clarify or feel free to ask more questions if my question was confusing

[soomineom]

This link (https://cloud.google.com/icons) says "During this transition period, we will not be updating the Powerpoint, Draw.IO, Lucidchart, SimpleDiagrams, or Cacoo resources.".

So I think we should think the most updated version is the icon without blue hexagon...
Thank you

[codeaucafe]

Ok thanks for confirm @soomineom, just wanted to make sure before I start working on this. I hope to get submit this PR by end of week, but I may have questions for you or @mingrammer before.

Thanks again for your help and letting me help you on this awesome project!!!

dd

[codeaucafe]

hey @mingrammer should I change the resource dirs to match the update icon set from GCP? I noticed the directories don't match the GCP resources directory's sub-directory names.

[codeaucafe]

hey @mingrammer and @soomineom I was wondering if you were able to take a look at my question. I wanted to get clarification before I really start working on this. Thanks in advance!!!!

[mingrammer]

@DataDavD Sorry for the late reply.

Sure! I think we can switch the outdated icons to the most updated icons without hexagons. But, the updating process seems to be a work in progress now. So, you should work on it after the final version is released.

And, if there are changes to the directory structure, we must release the next version with breaking changes release notes for existing users. While you work on this, please write the breaking change notes as well. (or we can do documentation together while reviewing the PRs.)

[mingrammer]

I assign this issue to you, @DataDavD.