Skip to content

Comments

enhance: Sync PyMilvus milvus-proto commit to v2.6.2#2995

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.6from
XuanYang-cn:cp26/mark-milvus-lite-optional
Sep 18, 2025
Merged

enhance: Sync PyMilvus milvus-proto commit to v2.6.2#2995
sre-ci-robot merged 1 commit intomilvus-io:2.6from
XuanYang-cn:cp26/mark-milvus-lite-optional

Conversation

@XuanYang-cn
Copy link
Contributor

this PR is a possible implementation addressing this #2975

- enhance: Make milvus-lite an optional dependency (milvus-io#2976)

this PR is a possible implementation addressing this
milvus-io#2975

Co-authored-by: Jagath Jai Kumar <jagath@xyla.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 12.84404% with 95 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.6@9d2556a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/grpc_gen/common_pb2.py 1.88% 52 Missing ⚠️
pymilvus/grpc_gen/msg_pb2.py 3.57% 27 Missing ⚠️
pymilvus/grpc_gen/milvus_pb2_grpc.py 50.00% 12 Missing ⚠️
pymilvus/orm/connections.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             2.6    #2995   +/-   ##
======================================
  Coverage       ?   46.42%           
======================================
  Files          ?       64           
  Lines          ?    12810           
  Branches       ?        0           
======================================
  Hits           ?     5947           
  Misses         ?     6863           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Sep 18, 2025
@yhmo
Copy link
Contributor

yhmo commented Sep 18, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit e9fbd2d into milvus-io:2.6 Sep 18, 2025
13 checks passed
@XuanYang-cn XuanYang-cn deleted the cp26/mark-milvus-lite-optional branch September 18, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants