Skip to content

Comments

enhance: Make milvus-lite an optional dependency#2976

Merged
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
jjaikumar-xyla:enhance/make-milvus-lite-optional
Sep 16, 2025
Merged

enhance: Make milvus-lite an optional dependency#2976
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
jjaikumar-xyla:enhance/make-milvus-lite-optional

Conversation

@jjaikumar-xyla
Copy link
Contributor

@jjaikumar-xyla jjaikumar-xyla commented Sep 8, 2025 •
edited
Loading

this PR is a possible implementation addressing this #2975

@sre-ci-robot
Copy link

sre-ci-robot commented Sep 8, 2025

Welcome @jjaikumar-xyla! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the needs-dco label Sep 8, 2025
@XuanYang-cn
Copy link
Contributor

XuanYang-cn commented Sep 9, 2025

@jjaikumar-xyla This PR's great, it'll reduce a lot of package size for pymilvus.

However the DCO robot is complaining. To be able to merge the pull requests, please follow the instruction to pass the DCO check: https://github.com/milvus-io/pymilvus/pull/2976/checks?check_run_id=49853038942

@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Sep 9, 2025
@jjaikumar-xyla jjaikumar-xyla force-pushed the enhance/make-milvus-lite-optional branch from c241abd to 8e413d5 Compare September 9, 2025 12:27
@jjaikumar-xyla
Copy link
Contributor Author

jjaikumar-xyla commented Sep 9, 2025

hi @XuanYang-cn thanks for the callout, I believe it should be fixed now!

@mergify mergify bot added dco-passed and removed needs-dco labels Sep 9, 2025
@XuanYang-cn
Copy link
Contributor

XuanYang-cn commented Sep 15, 2025

@jjaikumar-xyla The ut failed because we test milvus-lite in ut. Please mark it skip for now, I'll fix it properly later.

@jjaikumar-xyla
mark milvus-lite test with skip
5ae9575 
Signed-off-by: Jagath Jai Kumar <[email protected]>
@jjaikumar-xyla
Copy link
Contributor Author

jjaikumar-xyla commented Sep 15, 2025

/assign @czs007

@codecov
Copy link

codecov bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@c378eac). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/orm/connections.py 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2976   +/-   ##
=========================================
  Coverage          ?   46.46%           
=========================================
  Files             ?       63           
  Lines             ?    12724           
  Branches          ?        0           
=========================================
  Hits              ?     5912           
  Misses            ?     6812           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Sep 16, 2025
XuanYang-cn
XuanYang-cn approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

sre-ci-robot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjaikumar-xyla, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cabc1de into milvus-io:master Sep 16, 2025
13 checks passed
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Sep 18, 2025
@jjaikumar-xyla @XuanYang-cn
enhance: Sync PyMilvus milvus-proto commit to v2.6.2
ac004d1 
- enhance: Make milvus-lite an optional dependency (milvus-io#2976)

this PR is a possible implementation addressing this
milvus-io#2975

Co-authored-by: Jagath Jai Kumar <[email protected]>
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this pull request Sep 18, 2025
Merged
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Sep 18, 2025
sre-ci-robot pushed a commit that referenced this pull request Sep 18, 2025
@XuanYang-cn @jjaikumar-xyla
enhance: Sync PyMilvus milvus-proto commit to v2.6.2 (#2995)
e9fbd2d 
- enhance: Make milvus-lite an optional dependency (#2976)

this PR is a possible implementation addressing this
#2975

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: Jagath Jai Kumar <[email protected]>
Co-authored-by: Jagath Jai Kumar <[email protected]>
nathan-weinberg added a commit to nathan-weinberg/llama-stack-distribution that referenced this pull request Sep 18, 2025
@nathan-weinberg
fix: bring back milvus-lite
f55ada7 
milvus no longer includes milvus-lite by default
see: milvus-io/pymilvus#2976

this commit modifies our build script to include it
otherwise the inline::milvus provider fails on boot

Signed-off-by: Nathan Weinberg <[email protected]>
nathan-weinberg added a commit to nathan-weinberg/llama-stack-distribution that referenced this pull request Sep 18, 2025
@nathan-weinberg
fix: bring back milvus-lite
aaac55d 
milvus no longer includes milvus-lite by default
see: milvus-io/pymilvus#2976

this commit modifies our build script to include it
otherwise the inline::milvus provider fails on boot

Signed-off-by: Nathan Weinberg <[email protected]>
This was referenced Sep 18, 2025
Merged
Closed
nathan-weinberg added a commit to opendatahub-io/llama-stack-distribution that referenced this pull request Sep 18, 2025
@nathan-weinberg
fix: bring back milvus-lite (#44)
2b226dd 
# What does this PR do?
milvus no longer includes milvus-lite by default

see: milvus-io/pymilvus#2976

this commit modifies our build script to include it otherwise the
inline::milvus provider fails on boot

## Test Plan
CI should pass


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- New Features
- Enabled default support for Milvus Lite via pymilvus[milvus-lite],
simplifying local/vector DB usage.
- Chores
- Updated container configuration to install pymilvus with the
milvus-lite extra.
- Adjusted build process to automatically rewrite pymilvus dependencies
to include milvus-lite.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
leseb added a commit to leseb/llama-stack that referenced this pull request Sep 19, 2025
@leseb
fix: force milvus-lite installation for inline::milvus
a8f42d6 
pymilvus recently made `milvus-lite` an optional dependency to their
package. If someone wants to use the inline provider we must include the
extra dependency.
For more details see: milvus-io/pymilvus#2976

Signed-off-by: Sébastien Han <[email protected]>
@leseb leseb mentioned this pull request Sep 19, 2025
Merged
mattf pushed a commit to llamastack/llama-stack that referenced this pull request Sep 19, 2025
@leseb
fix: force milvus-lite installation for inline::milvus (#3488)
d3600b9 
# What does this PR do?

pymilvus recently made `milvus-lite` an optional dependency to their
package. If someone wants to use the inline provider we must include the
extra dependency.
For more details see: milvus-io/pymilvus#2976

Signed-off-by: Sébastien Han <[email protected]>
bjhargrave added a commit to ibm-granite-community/granite-snack-cookbook that referenced this pull request Sep 21, 2025
@bjhargrave
Must now install milvus-lite to use a local Milvus DB
ecdf929 
https: //github.com/milvus-io/pymilvus/pull/2976
Signed-off-by: BJ Hargrave <[email protected]>
bjhargrave added a commit to IBM/granite-workshop that referenced this pull request Sep 21, 2025
@bjhargrave
Must now install milvus-lite to use a local Milvus DB
b2d2d99 
https: //github.com/milvus-io/pymilvus/pull/2976
Signed-off-by: BJ Hargrave <[email protected]>
bjhargrave added a commit to ibm-granite-community/granite-snack-cookbook that referenced this pull request Sep 21, 2025
@bjhargrave
Must now install milvus-lite to use a local Milvus DB
88f42ad 
https: //github.com/milvus-io/pymilvus/pull/2976
Signed-off-by: BJ Hargrave <[email protected]>
bjhargrave added a commit to ibm-granite-community/docling-workshop that referenced this pull request Sep 21, 2025
@bjhargrave
Must now install milvus-lite to use a local Milvus DB
69ee23a 
https: //github.com/milvus-io/pymilvus/pull/2976
Signed-off-by: BJ Hargrave <[email protected]>
bjhargrave added a commit to ibm-granite-community/granite-legal-cookbook that referenced this pull request Sep 21, 2025
@bjhargrave
Must now install milvus-lite to use a local Milvus DB
3d25a71 
https: //github.com/milvus-io/pymilvus/pull/2976
Signed-off-by: BJ Hargrave <[email protected]>
bjhargrave added a commit to ibm-granite-community/granite-legal-cookbook that referenced this pull request Sep 21, 2025
@bjhargrave
Must now install milvus-lite to use a local Milvus DB
e444e98 
https: //github.com/milvus-io/pymilvus/pull/2976
Signed-off-by: BJ Hargrave <[email protected]>
iamemilio pushed a commit to iamemilio/llama-stack that referenced this pull request Sep 24, 2025
@leseb @iamemilio
fix: force milvus-lite installation for inline::milvus (llamastack#3488)
2181f71 
# What does this PR do?

pymilvus recently made `milvus-lite` an optional dependency to their
package. If someone wants to use the inline provider we must include the
extra dependency.
For more details see: milvus-io/pymilvus#2976

Signed-off-by: Sébastien Han <[email protected]>
skamenan7 pushed a commit to skamenan7/llama-stack-distribution that referenced this pull request Nov 17, 2025
@nathan-weinberg @skamenan7
fix: bring back milvus-lite
ac4920d 
milvus no longer includes milvus-lite by default
see: milvus-io/pymilvus#2976

this commit modifies our build script to include it
otherwise the inline::milvus provider fails on boot

Signed-off-by: Nathan Weinberg <[email protected]>
@nathan-weinberg nathan-weinberg mentioned this pull request Dec 20, 2025
Merged
sre-ci-robot pushed a commit to milvus-io/milvus that referenced this pull request Dec 23, 2025
@nathan-weinberg
doc: fix quickstart section for Milvus Lite (#46474)
9f63a5c 
### **User description**
As of milvus-io/pymilvus#2976 `milvus-lite` is
no longer included as part of the default `pymilvus` installation and
must be explicitly specified


___

### **PR Type**
Documentation


___

### **Description**
- Update installation docs to reflect milvus-lite as optional dependency

- Clarify explicit installation requirement for Milvus Lite
functionality


___

### Diagram Walkthrough


```mermaid
flowchart LR
  A["pymilvus default install"] -- "does not include" --> B["Milvus Lite"]
  C["pymilvus[milvus-lite]"] -- "includes" --> B
  B -- "enables" --> D["Local vector database"]
```



<details><summary><h3>File Walkthrough</h3></summary>

<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>README.md</strong><dd><code>Clarify Milvus Lite as
optional dependency</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

README.md

<ul><li>Updated installation documentation to clarify that
<code>milvus-lite</code> is no <br>longer included by default<br> <li>
Changed wording from "includes Milvus Lite" to "can try Milvus Lite by
<br>installing <code>pymilvus[milvus-lite]</code>"<br> <li> Reflects the
breaking change from pymilvus PR #2976 where milvus-lite <br>became an
optional dependency</ul>


</details>


  </td>
<td><a
href="https://github.com/milvus-io/milvus/pull/46474/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>
</table></td></tr></tbody></table>

</details>

___



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated Milvus Lite installation guidance to specify the proper
installation method using the optional feature specification.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Nathan Weinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn approved these changes

@czs007 czs007 Awaiting requested review from czs007

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@XuanYang-cn XuanYang-cn

@czs007 czs007

Labels

approved ci-passed dco-passed lgtm PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jjaikumar-xyla @sre-ci-robot @XuanYang-cn @czs007