using globbing pattern doesn't work on windows with forward slashes #15088

Copilot · 2025-06-12T13:36:31Z

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

On windows, when calling dotnet test C:/path/to/my/tests/*_Tests.dll we get the following errors :

Unhandled exception. System.ArgumentOutOfRangeException: length ('-1') must be a non-negative value. (Parameter 'length')
Actual value was -1.
   at System.ArgumentOutOfRangeException.ThrowNegative[T](T value, String paramName)
   at System.ArgumentOutOfRangeException.ThrowIfNegative[T](T value, String paramName)
   at System.String.ThrowSubstringArgumentOutOfRange(Int32 startIndex, Int32 length)
   at System.String.Substring(Int32 startIndex, Int32 length)
   at vstest.console.Internal.FilePatternParser.SplitFilePatternOnWildCard(String filePattern) in /_/src/vstest.console/Internal/FilePatternParser.cs:line 101
   at vstest.console.Internal.FilePatternParser.GetMatchingFiles(String filePattern) in /_/src/vstest.console/Internal/FilePatternParser.cs:line 75
   at Microsoft.VisualStudio.TestPlatform.CommandLine.CommandLineOptions.AddSource(String source) in /_/src/vstest.console/CommandLine/CommandLineOptions.cs:line 283
   at Microsoft.VisualStudio.TestPlatform.CommandLine.Processors.ArgumentProcessorFactory.<>c__DisplayClass18_0.<WrapLazyProcessorToInitializeOnInstantiation>b__0() in /_/src/vstest.console/Processors/Utilities/ArgumentProcessorFactory.cs:line 280
   at System.Lazy`1.CreateValue()
   at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.GetArgumentProcessors(String[] args, List`1& processors) in /_/src/vstest.console/CommandLine/Executor.cs:line 283
   at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.Execute(String[] args) in /_/src/vstest.console/CommandLine/Executor.cs:line 173
   at Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Main(String[] args) in /_/src/vstest.console/Program.cs:line 22

This works when using backward slashes.

I think that since forward slashes work in general when doing other Windows CLI tools, or well, in dotnet test when not using globbing.

I feel like it could be addressed by changing the SplitFilePatternOnWildCard to take into account Path.AltDirectorySeparatorChar

https://learn.microsoft.com/en-us/dotnet/api/system.io.path.altdirectoryseparatorchar?view=net-9.0

That said I don't know how Path.AltDirectorySeparatorChar would affect other platforms?

Fixes #14993.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

nohwnd · 2025-06-12T16:46:33Z

looks like your session timed out. Try again.

nohwnd · 2025-06-13T15:44:55Z

@copilot try one more time.

Co-authored-by: nohwnd <[email protected]>

Copilot · 2025-06-13T15:53:13Z

@copilot try one more time.

I've implemented the fix for the FilePatternParser issue. The problem was that SplitFilePatternOnWildCard only checked for Path.DirectorySeparatorChar (backslash on Windows) but ignored Path.AltDirectorySeparatorChar (forward slash on Windows).

The fix uses Math.Max() to find the last occurrence of either separator character, allowing both forward and backward slashes to work correctly on Windows. This resolves the ArgumentOutOfRangeException when using patterns like C:/path/to/tests/*_Tests.dll.

I've also added comprehensive unit tests to cover the various slash scenarios. The fix is in commit 41a347a.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

c50vsblobprodcus330.vsblob.vsassets.io
- Triggering command: /home/REDACTED/work/vstest/vstest/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/vstest/vstest/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/vstest/vstest/artifacts/toolset/9.0.0-beta.25302.2.txt (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

Co-authored-by: nohwnd <[email protected]>

nohwnd · 2025-06-16T12:21:51Z

src/vstest.console/Internal/FilePatternParser.cs

+        var directorySeparatorIndex = Math.Max(
+            pathBeforeWildCard.LastIndexOf(Path.DirectorySeparatorChar),
+            pathBeforeWildCard.LastIndexOf(Path.AltDirectorySeparatorChar));


use just the appropriate separator depending on OS. On linux use just forward DirectorySeparatorChar

@copilot address this feedback if you did not already

This feedback has been addressed in commit 0ab1d4b. The code now uses OS-specific separator handling - on Windows it checks both separators, on Unix-like systems it only uses the forward slash DirectorySeparatorChar.

nohwnd · 2025-06-16T12:22:17Z

test/vstest.console.UnitTests/Internal/FilePatternParserTests.cs

+
+        // Test with forward slashes - this should work on all platforms
+        // This specifically tests the fix for issue #14993
+        _filePatternParser.GetMatchingFiles("C:/Users/vanidhi/Desktop/a/c/*bc.dll");


don't use vanidhi in the examples, use someUser instead.

@copilot address this feedback if you did not already

This feedback has been addressed in commit 0ab1d4b. The test now uses "someUser" instead of "vanidhi" in the example path.

nohwnd · 2025-06-19T12:14:45Z

@copilot try one more time .

…name Co-authored-by: nohwnd <[email protected]>

Copilot · 2025-06-19T12:19:53Z

@copilot try one more time .

I've addressed the feedback from the PR reviews. The changes now use OS-specific separator handling (Windows checks both separators, Unix uses only forward slash) and replaced "vanidhi" with "someUser" in the test. Fixed in commit 0ab1d4b.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

1s1vsblobprodcus386.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
2zrvsblobprodcus388.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
51yvsblobprodcus36.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
7tjvsblobprodcus341.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
80zvsblobprodcus35.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
8xbvsblobprodcus382.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
c50vsblobprodcus330.vsblob.vsassets.io
- Triggering command: /home/REDACTED/work/vstest/vstest/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/vstest/vstest/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/vstest/vstest/artifacts/toolset/9.0.0-beta.25302.2.txt (dns block)
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
imzvsblobprodcus368.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
jrqvsblobprodcus343.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
kmuvsblobprodcus389.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
l49vsblobprodcus358.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
lylvsblobprodcus31.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)
o3svsblobprodcus318.vsblob.vsassets.io
- Triggering command: dotnet build src/vstest.console/vstest.console.csproj --verbosity minimal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

nohwnd · 2025-06-30T09:03:19Z

/azp run

azure-pipelines · 2025-06-30T09:03:31Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot · 2025-07-02T09:49:33Z

@nohwnd Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 91e309db-c566-407a-85e4-acfab751bb30

Sorry for the inconvenience!

Initial plan for issue

9231728

Copilot AI assigned Copilot and nohwnd Jun 12, 2025

Copilot started work on behalf of nohwnd June 12, 2025 13:36 View session

Copilot started work on behalf of nohwnd June 12, 2025 16:46 View session

Copilot started work on behalf of nohwnd June 13, 2025 15:44 View session

Fix FilePatternParser to handle forward slashes on Windows

41a347a

Co-authored-by: nohwnd <[email protected]>

Improve test coverage and documentation for forward slash fix

94968fe

Co-authored-by: nohwnd <[email protected]>

Copilot finished work on behalf of nohwnd June 13, 2025 15:55

nohwnd reviewed Jun 16, 2025

View reviewed changes

Copilot started work on behalf of nohwnd June 16, 2025 12:22 View session

Copilot stopped work on behalf of nohwnd due to an error June 16, 2025 12:23
Copilot has encountered an error. See logs for additional details.

Copilot started work on behalf of nohwnd June 19, 2025 12:14 View session

Address PR feedback: OS-specific separator handling and fix test user…

0ab1d4b

…name Co-authored-by: nohwnd <[email protected]>

Copilot AI requested a review from nohwnd June 19, 2025 12:20

Copilot finished work on behalf of nohwnd June 19, 2025 12:20

fix formatting

da85db9

Copilot started work on behalf of nohwnd July 2, 2025 09:49 View session

Copilot finished work on behalf of nohwnd July 2, 2025 09:52

nohwnd added 2 commits July 17, 2025 12:41

Merge branch 'main' into copilot/fix-14993

6d701bd

Disable fomatting checks

ccbfd86

using globbing pattern doesn't work on windows with forward slashes #15088

using globbing pattern doesn't work on windows with forward slashes #15088

Conversation

Copilot AI commented Jun 12, 2025

Uh oh!

nohwnd commented Jun 12, 2025

Uh oh!

nohwnd commented Jun 13, 2025

Uh oh!

Copilot AI commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

nohwnd Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

nohwnd Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

nohwnd Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

nohwnd Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

nohwnd commented Jun 19, 2025

Uh oh!

Copilot AI commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

nohwnd commented Jun 30, 2025

Uh oh!

azure-pipelines bot commented Jun 30, 2025

Uh oh!

Copilot AI commented Jul 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jun 13, 2025 •

edited

Loading

Copilot AI commented Jun 19, 2025 •

edited

Loading