Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 18, 2025

Fixes dotnet/source-build#4996

Build TestPlatform packages in VMR but with the MIT license instead of the VS one, as discussed in the issue. We don't ship those packages so that should be fine.

Validation build: dotnet/sdk#48571

but with the MIT license instead of VS.

Fixes dotnet/source-build#4996
Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, as long as they are never shipped with that license.

@nohwnd nohwnd merged commit 65a8297 into main Apr 21, 2025
7 checks passed
@nohwnd nohwnd deleted the BuildTestPlatformPackagesInVMR branch April 21, 2025 20:00
ViktorHofer added a commit that referenced this pull request Apr 22, 2025
nohwnd pushed a commit that referenced this pull request Apr 22, 2025
This was referenced Oct 2, 2025
This was referenced Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.TestPlatform and Microsoft.TestPlatform.Portable packages missing from VMR

3 participants