Skip to content

Remove experimental from WCO enable setting name #167064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove experimental from WCO enable setting name #167064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43e20f3
Remove experimental from WCO enable setting name
rzhao271 Nov 23, 2022
6826ba1
Shorten setting name
rzhao271 Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/platform/window/common/window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export function useWindowControlsOverlay(configurationService: IConfigurationSer
return false; // only supported when title bar is custom
}

const configuredUseWindowControlsOverlay = configurationService.getValue<boolean | undefined>('window.experimental.windowControlsOverlay.enabled');
const configuredUseWindowControlsOverlay = configurationService.getValue<boolean | undefined>('window.enableWindowControlsOverlay');
if (typeof configuredUseWindowControlsOverlay === 'boolean') {
return configuredUseWindowControlsOverlay;
}
Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ interface IConfiguration extends IWindowsConfiguration {
debug?: { console?: { wordWrap?: boolean } };
editor?: { accessibilitySupport?: 'on' | 'off' | 'auto' };
security?: { workspace?: { trust?: { enabled?: boolean } } };
window: IWindowSettings & { experimental?: { windowControlsOverlay?: { enabled?: boolean }; useSandbox?: boolean } };
window: IWindowSettings & { enableWindowControlsOverlay?: boolean; experimental?: { useSandbox?: boolean } };
workbench?: { experimental?: { settingsProfiles?: { enabled?: boolean } }; enableExperiments?: boolean };
extensions?: { experimental?: { useUtilityProcess?: boolean } };
_extensionsGallery?: { enablePPE?: boolean };
Expand Down Expand Up @@ -73,7 +73,7 @@ export class SettingsChangeRelauncher extends Disposable implements IWorkbenchCo
processChanged((config.window.titleBarStyle === 'native' || config.window.titleBarStyle === 'custom') && this.titleBarStyle.handleChange(config.window?.titleBarStyle));

// Windows: Window Controls Overlay
processChanged(isWindows && this.windowControlsOverlayEnabled.handleChange(config.window?.experimental?.windowControlsOverlay?.enabled));
processChanged(isWindows && this.windowControlsOverlayEnabled.handleChange(config.window?.enableWindowControlsOverlay));

// Windows: Sandbox
processChanged(this.windowSandboxEnabled.handleChange(config.window?.experimental?.useSandbox));
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/electron-sandbox/desktop.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ import product from 'vs/platform/product/common/product';
'scope': ConfigurationScope.APPLICATION,
'description': localize('titleBarStyle', "Adjust the appearance of the window title bar. On Linux and Windows, this setting also affects the application and context menu appearances. Changes require a full restart to apply.")
},
'window.experimental.windowControlsOverlay.enabled': {
'window.enableWindowControlsOverlay': {
'type': 'boolean',
'default': true,
'scope': ConfigurationScope.APPLICATION,
Expand Down