Skip to content

Remove experimental from WCO enable setting name #167064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove experimental from WCO enable setting name #167064

wants to merge 2 commits into from

Conversation

@rzhao271
Copy link
Collaborator

@rzhao271 rzhao271 commented Nov 23, 2022

Ref #161218
Ref #167060

@rzhao271 rzhao271 enabled auto-merge (squash) November 23, 2022 15:31
@rzhao271 rzhao271 self-assigned this Nov 23, 2022
@rzhao271 rzhao271 requested review from bpasero and sbatten November 23, 2022 15:31
@rzhao271 rzhao271 added this to the November 2022 milestone Nov 23, 2022
bpasero
bpasero requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting more settings for windowControlsOverlay or not, because if not I think I would prefer a shorter key.

@rzhao271
Copy link
Collaborator Author

rzhao271 commented Nov 23, 2022 •
edited
Loading

I don't expect more settings for the WCO. I renamed the setting.

@rzhao271 rzhao271 requested a review from bpasero November 23, 2022 19:10
@bpasero bpasero removed their request for review November 24, 2022 05:32
@bpasero
Copy link
Member

bpasero commented Nov 24, 2022 •
edited
Loading

👍 , leaving it to @sbatten for this one.

@rzhao271 fyi with auto merge enabled, the first one that reviews gets the PR merged, so I suggest if you seek input from multiple people to disable auto merge.

@rzhao271 rzhao271 disabled auto-merge November 28, 2022 16:03
@sbatten
Copy link
Member

sbatten commented Nov 28, 2022

Actually, now that I think about it, we don't really need/want to do this rename. The setting should not exist in the long term. There is no reason for us to support disabling the WCO if they function well. The setting just allows opting out in case there are early adoption issues.

@rzhao271
Copy link
Collaborator Author

rzhao271 commented Nov 28, 2022

SGTM
Closing

@rzhao271 rzhao271 closed this Nov 28, 2022
@rzhao271 rzhao271 deleted the bizarre-trout branch November 28, 2022 18:54
@bpasero
Copy link
Member

bpasero commented Nov 29, 2022

Yup agree, +1 if we end up removing this setting altogether.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bpasero bpasero bpasero requested changes

@sbatten sbatten Awaiting requested review from sbatten

Assignees

@rzhao271 rzhao271

Labels

None yet

Projects

None yet

Milestone

November 2022

Development

Successfully merging this pull request may close these issues.

4 participants

@rzhao271 @bpasero @sbatten