Add regression test for inlay hints crash on reparsed nodes

internal/fourslash/tests/manual/inlayHintsCrashReparsed_test.go

@@ -0,0 +1,31 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/typescript-go/internal/fourslash"
+	"github.com/microsoft/typescript-go/internal/ls/lsutil"
+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestInlayHintsCrashReparsed(t *testing.T) {
+	t.Parallel()
+
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `
+// @allowJs: true
+// @checkJs: true
+
+// @Filename: /a.js
+module.exports = function () {
+  return 1;
+};
+`
+
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+	f.VerifyBaselineInlayHints(t, nil /*span*/, &lsutil.UserPreferences{InlayHints: lsutil.InlayHintsPreferences{
+		IncludeInlayFunctionLikeReturnTypeHints: true,
+		IncludeInlayFunctionParameterTypeHints:  true,
+	}})
+}

internal/ls/inlay_hints.go

@@ -61,7 +61,7 @@ type inlayHintState struct {
 }
 
 func (s *inlayHintState) visit(node *ast.Node) bool {
-	if node == nil || node.End()-node.Pos() == 0 {
+	if node == nil || node.End()-node.Pos() == 0 || node.Flags&ast.NodeFlagsReparsed != 0 {
 		return false
 	}
 

testdata/baselines/reference/submodule/fourslash/inlayHints/inlayHintsCrashReparsed.baseline

@@ -0,0 +1,19 @@
+// === Inlay Hints ===
+module.exports = function () {
+                            ^
+{
+  "position": {
+    "line": 0,
+    "character": 28
+  },
+  "label": [
+    {
+      "value": ": "
+    },
+    {
+      "value": "number"
+    }
+  ],
+  "kind": 1,
+  "paddingLeft": true
+}

testdata/baselines/reference/submodule/fourslash/inlayHints/inlayHintsCrashReparsed.baseline.diff

@@ -0,0 +1,18 @@
+--- old.inlayHintsCrashReparsed.baseline
++++ new.inlayHintsCrashReparsed.baseline
+@@= skipped --1, +0 lines =@@
++// === Inlay Hints ===
++module.exports = function () {
++                            ^
++{
++  "label": [
++    {
++      "value": ": "
++    },
++    {
++      "value": "number"
++    }
++  ],
++  "kind": 1,
++  "paddingLeft": true
++}