Add regression test for inlay hints crash on reparsed nodes #2595

Copilot · 2026-01-27T19:33:49Z

Adds a regression test for issue #2460 where textDocument/inlayHint panics on reparsed AST nodes (specifically reparsed function expressions in JavaScript module exports).

Test coverage:

New TestInlayHintsOnModuleExportsWithFunctionExpression (in inlayHintsInJavaScriptCjsFile_test.go) reproduces the crash scenario
Passes with the existing fix (checking NodeFlagsReparsed)
Fails without the fix with: "Cannot create token from reparsed node of kind KindFunctionExpression"

The test case:

// @allowJs: true
// @checkJs: true
// @Filename: /a.js
module.exports = function () {
  return 1;
};

Follows the pattern of existing fourslash-based inlay hint tests. Test is placed in internal/fourslash/tests/ as a new regression test for typescript-go.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: DanielRosenwasser <[email protected]>

jakebailey · 2026-01-28T01:15:32Z

...ata/baselines/reference/submodule/fourslash/inlayHints/inlayHintsCrashReparsed.baseline.diff

@@ -0,0 +1,18 @@
+--- old.inlayHintsCrashReparsed.baseline
+++ new.inlayHintsCrashReparsed.baseline


Why is this getting a diff?

Removed in commit 28b2b1b. The .diff file was inappropriately generated for a new test - diff files are only for tests ported from TypeScript to show behavioral differences.

DanielRosenwasser · 2026-01-28T01:15:19Z

internal/fourslash/tests/inlayHintsInJavaScriptCjsFile_test.go

@copilot Rename test to

inlayHintsInJavaScriptCjsFile._test.go

Also, is this the right directory?

Done in commit 28b2b1b. Renamed test file to inlayHintsInJavaScriptCjsFile_test.go and kept it in the manual directory since it's a manually created test (not ported from TypeScript).

Yes, the manual directory is appropriate for this test. Tests in manual/ are manually created (not ported from TypeScript), and tests in gen/ are automatically generated from TypeScript's fourslash tests. This is a new regression test specific to typescript-go, so it belongs in manual/.

Wrong, manual are for generated tests that have been "promoted" to a handwritten onr

@copilot obey.

Moved to gen/ directory in commit 64d56f3.

No, they go in tests directly

@copilot try again

Moved to tests/ directory in commit 787b4bd.

DanielRosenwasser · 2026-01-28T01:15:46Z

internal/fourslash/tests/manual/inlayHintsCrashReparsed_test.go

+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestInlayHintsCrashReparsed(t *testing.T) {


Suggested change

func TestInlayHintsCrashReparsed(t *testing.T) {

func TestInlayHintsOnModuleExportsWithFunctionExpression(t *testing.T) {

Done in commit 28b2b1b.

Co-authored-by: DanielRosenwasser <[email protected]>

ahejlsberg and others added 2 commits January 27, 2026 10:36

Exclude reparsed nodes from inlay hints

08e244a

Initial plan

3b8aadb

Copilot AI assigned Copilot and DanielRosenwasser Jan 27, 2026

Copilot AI mentioned this pull request Jan 27, 2026

Exclude reparsed nodes from inlay hints #2593

Merged

Copilot started work on behalf of DanielRosenwasser January 27, 2026 19:37 View session

Add regression test for inlay hints crash on reparsed nodes

b7c0a22

Co-authored-by: DanielRosenwasser <[email protected]>

Copilot AI changed the title ~~[WIP] Fix inlay hint issue with reparsed nodes~~ Add regression test for inlay hints crash on reparsed nodes Jan 27, 2026

Copilot AI requested a review from DanielRosenwasser January 27, 2026 19:47

Copilot finished work on behalf of DanielRosenwasser January 27, 2026 19:47

DanielRosenwasser marked this pull request as ready for review January 27, 2026 21:24

Base automatically changed from fix-2460 to main January 27, 2026 21:40

DanielRosenwasser approved these changes Jan 28, 2026

View reviewed changes

jakebailey reviewed Jan 28, 2026

View reviewed changes

DanielRosenwasser requested changes Jan 28, 2026

View reviewed changes

Copilot started work on behalf of DanielRosenwasser January 28, 2026 01:16 View session

Rename test file and function per review feedback

28b2b1b

Co-authored-by: DanielRosenwasser <[email protected]>

Copilot AI requested a review from DanielRosenwasser January 28, 2026 01:27

Copilot finished work on behalf of DanielRosenwasser January 28, 2026 01:27

Copilot started work on behalf of DanielRosenwasser January 28, 2026 06:21 View session

Copilot AI and others added 2 commits January 28, 2026 06:27

Move test from manual/ to gen/ directory

64d56f3

Co-authored-by: DanielRosenwasser <[email protected]>

Add regression test for inlay hints crash on reparsed nodes

4b5d349

Co-authored-by: DanielRosenwasser <[email protected]>

Copilot finished work on behalf of DanielRosenwasser January 28, 2026 06:29

Copilot started work on behalf of DanielRosenwasser January 29, 2026 22:47 View session

Move test to tests/ directory (not gen/ or manual/)

787b4bd

Co-authored-by: DanielRosenwasser <[email protected]>

Copilot finished work on behalf of DanielRosenwasser January 29, 2026 22:58

		@@ -0,0 +1,18 @@
		--- old.inlayHintsCrashReparsed.baseline
		+++ new.inlayHintsCrashReparsed.baseline

	func TestInlayHintsCrashReparsed(t *testing.T) {
	func TestInlayHintsOnModuleExportsWithFunctionExpression(t *testing.T) {

Add regression test for inlay hints crash on reparsed nodes #2595

Are you sure you want to change the base?

Add regression test for inlay hints crash on reparsed nodes #2595

Conversation

Copilot AI commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jan 27, 2026 •

edited

Loading