Skip to content

Port "Fixed a JSDoc-related crash when obtaining type of a type literal type argument" #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Jun 4, 2025
Merged

Port "Fixed a JSDoc-related crash when obtaining type of a type literal type argument" #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21669,7 +21669,7 @@ func (c *Checker) getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode(node *as
if links.resolvedType == nil {
// Deferred resolution of members is handled by resolveObjectTypeMembers
alias := c.getAliasForTypeNode(node)
if len(c.getMembersOfSymbol(node.Symbol())) == 0 && alias == nil {
if sym := node.Symbol(); sym == nil || len(c.getMembersOfSymbol(sym)) == 0 && alias == nil {
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding parentheses around the second part of the condition to clarify operator precedence, e.g., sym == nil || (len(c.getMembersOfSymbol(sym)) == 0 && alias == nil).

Copilot uses AI. Check for mistakes.
links.resolvedType = c.emptyTypeLiteralType
} else {
t := c.newObjectType(ObjectFlagsAnonymous, node.Symbol())
Expand Down