Port "Fixed a JSDoc-related crash when obtaining type of a type literal type argument" #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al type argument"
Contributor
There was a problem hiding this comment.
Pull Request Overview
Ports the fix from the TypeScript repo to prevent a JSDoc-related crash when obtaining the type of a type literal type argument by adding a nil check and caching the symbol before use.
- Introduce a local
symvariable to storenode.Symbol() - Add
sym == nilcheck in the condition to avoid dereferencingnil
| // Deferred resolution of members is handled by resolveObjectTypeMembers | ||
| alias := c.getAliasForTypeNode(node) | ||
| if len(c.getMembersOfSymbol(node.Symbol())) == 0 && alias == nil { | ||
| if sym := node.Symbol(); sym == nil || len(c.getMembersOfSymbol(sym)) == 0 && alias == nil { |
There was a problem hiding this comment.
[nitpick] Consider adding parentheses around the second part of the condition to clarify operator precedence, e.g., sym == nil || (len(c.getMembersOfSymbol(sym)) == 0 && alias == nil).
jakebailey
approved these changes
Jun 4, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
We don't have the tests for this yet but this looks correct to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60358