[rel/3.8] Fix serialization of exceptions by BinaryFormatter in .NET Framework #5055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
previously approved these changes
Feb 18, 2025
Member
|
Failed on output not mixed tests, looks like flakiness. |
Member
|
Member
|
I was looking specifically for that in local run of unit tests and saw just the integration tests fail. Same as here in the failed tests: dammit such complicated reporting (not your fault of course). |
Member
|
fixing on the original, where we are also discussing the approach. |
auto-merge was automatically disabled
February 18, 2025 15:02
Head branch was pushed to by a user without write access
youssef-backport-bot
force-pushed
the
backport/5054/to/rel/3.8
branch
from
32c95a2 to
46c08e7
Compare
Youssef1313
reviewed
Feb 18, 2025
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5054 to rel/3.8
/cc @Evangelink @nohwnd