Implement PGO in pipelines for AMD64 architecture; supply training test scenarios#10071
Merged
42 commits merged intomainfrom May 13, 2021
Merged
Implement PGO in pipelines for AMD64 architecture; supply training test scenarios#1007142 commits merged intomainfrom
42 commits merged intomainfrom
Conversation
This was referenced Oct 29, 2023
This was referenced Nov 11, 2023
Evaluate using Profile-Guided Optimization (PGO) and Post Link Optimization (PLO)
sharkdp/numbat#257
Closed
This was referenced Nov 19, 2023
This was referenced Nov 26, 2023
Open
This was referenced Jan 28, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement PGO in pipelines for AMD64 architecture; supply training test scenarios
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Microsoft.Internal.Windows.Terminal.PGODatabaseMicrosoft.Internal.Windows.Terminal.TestContentThe following binaries are trained:
In the future, adding
<PgoTarget>true</PgoTarget>to a newvcxprojfile will automatically enroll the DLL/EXE for PGO instrumentation and optimization going forward.Two training test scenarios are implemented:
big.txt, then exiting.Additional scenarios can be contributed to the
WindowsTerminal_UIATestsproject with the[TestProperty("IsPGO", "true")]annotation to add them to the suite of scenarios for PGO.NOTE: There are currently no weights applied to the various test scenarios. We will revisit that in the future when/if necessary.
Validation Steps Performed
PGOBuildModetoOptimizeon my local machine, manually retrieving the databases with NuGet, and building).big.txtoutput through CMD is ~11-12seconds prior to PGO and just over 8 seconds with PGO.