Skip to content

Add Japanese and Chinese mobile number test cases for PhoneRecognizer #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SharonHart merged 9 commits into from
Dec 16, 2025
Merged

Add Japanese and Chinese mobile number test cases for PhoneRecognizer #1808

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3bb79c
Add Japanese and Chinese mobile number test cases
WenwenHLF Dec 4, 2025
49ac2e7
Extend phone number tests to include JP and CN using supported_region…
WenwenHLF Dec 4, 2025
c18df4b
Merge branch 'main' into main
RonShakutai Dec 7, 2025
fd5c354
Merge branch 'main' into main
SharonHart Dec 8, 2025
f7acf89
Merge branch 'main' into main
WenwenHLF Dec 11, 2025
f22f6ca
Merge branch 'main' into main
omri374 Dec 12, 2025
bd9276f
Merge branch 'main' into main
SharonHart Dec 15, 2025
b783119
Merge branch 'main' into main
SharonHart Dec 16, 2025
49d633f
Merge branch 'main' into main
SharonHart Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions presidio-analyzer/tests/test_phone_recognizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@

@pytest.fixture(scope="module")
def recognizer():
return PhoneRecognizer()
return PhoneRecognizer(
supported_regions=PhoneRecognizer.DEFAULT_SUPPORTED_REGIONS + ("JP", "CN")
)



Expand All @@ -24,6 +26,8 @@ def recognizer():
("_: +55 11 98456 5666", 1, ["PHONE_NUMBER"], ((3, 20), ), 0.4),
("Brazil: +55 11 98456 5666", 1, ["PHONE_NUMBER"], ((8, 25), ), 0.4),
("BR: +55 11 98456 5666", 1, ["PHONE_NUMBER"], ((4, 21), ), 0.4),
("My Japanese number is 090-1234-5678", 1, ["PHONE_NUMBER"],((22, 35), ), 0.4),
("My CN number is 13812345678", 1, ["PHONE_NUMBER"],((16, 27), ), 0.4),
# fmt: on
],
)
Expand Down Expand Up @@ -135,4 +139,4 @@ def test_get_analysis_explanation():
phone_recognizer = PhoneRecognizer()
test_region = "US"
explanation = phone_recognizer._get_analysis_explanation(test_region)
assert explanation.recognizer == "PhoneRecognizer"
assert explanation.recognizer == "PhoneRecognizer"