Add Japanese and Chinese mobile number test cases for PhoneRecognizer #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds international PHONE_NUMBER test cases for Presidio Analyzer: - Japanese mobile number formats: 090/080/070 - Chinese mobile number formats: 11-digit numbers starting with 1 These tests improve international coverage for the PhoneRecognizer.
Contributor
|
Hi @WenwenHLF, Presidio has a few default regions for the phone recognizers. Japan and China are not part of the default, so it's likely not going to work. If you'd like, add Japan and China to the supported regions in the test. recognizer = PhoneRecognizer(leniency=leniency)See this comment for more info on defining regions: |
…s override
This update adds Japanese and Chinese phone number examples to the phone recognizer test suite. The recognizer fixture is extended with supported_regions = DEFAULT_SUPPORTED_REGIONS + ("JP", "CN") so that the new cases can be detected without changing the library’s default behavior.
Only the test fixture is modified; leniency and other tests remain unchanged.
Author
|
Hi @omri374 , Thanks for the suggestion! I've updated the test fixture so that PhoneRecognizer is initialized with JP and CN added to supported_regions. This allows the new test cases to pass without modifying the default regions. |
SharonHart
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This commit adds international PHONE_NUMBER test cases for Presidio Analyzer:
These tests improve international coverage for the PhoneRecognizer.
Checklist