Skip to content

Conversation

@oliviacrain
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Our azurevm package list contains python-xml, which was removed in #2604. This package was listed due to our 1.0 image requiring Python 2 XML libraries for the purpose of running Azure VM extensions. In this PR, we change the requirement from python-xml to python3, since (a) the extensions install just fine with Python 3, (b) we folded Python 3's XML libraries into the python3-libs package for 2.0, and (c) the extension actually requires /usr/bin/python3 (which is in the python3 package, which depends on python3-libs).

Cherry-pick of #2667 to the main branch.

Change Log
  • azurevm-packagelist.json: Change python-xml requirement to python3
Does this affect the toolchain?

NO

Test Methodology
  • Local build of image

@oliviacrain oliviacrain requested a review from a team as a code owner April 5, 2022 16:03
@ghost ghost added Schema Changes to image configurations main PR Destined for main labels Apr 5, 2022
@oliviacrain oliviacrain merged commit 3c49f0c into main Apr 5, 2022
@oliviacrain oliviacrain deleted the olivia/remove-py2-azurevm branch April 5, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Schema Changes to image configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants