Remove python2 support from Mariner #2604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
./cgmanifest.json,./toolkit/tools/cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Python 2 end-of-life was January 1, 2020. Python 2 no longer receives security updates from upstream, which hurts our security posture. Additionally, many packages are dropping support for Python 2, which makes maintaining Python 2 support a burden on our package upgrade efforts.
So, in light of that, let's remove our
python2package!Thanks to a lot of incremental
python2removal work across the past few months, we are finally in a position where removal is possible. This PR removes thepython2package, alongsidepython2subpackages and macros.Change Log
python2python-setuptoolsandpython-pipmariner-rpm-macrospython2subpackages frompython-six,python-setuptools_scmpython2-setuptoolsrequirement inmercurialDoes this affect the toolchain?
YES
Test Methodology