Skip to content

Conversation

@Kanchan-Microsoft
Copy link
Contributor

Purpose

This pull request updates the tagging logic for resource groups and makes a minor fix to resource dependencies in the infrastructure templates. The main improvements are ensuring that existing resource group tags are preserved and merged with new tags, and correcting the order of dependencies for private DNS zones.

Tagging improvements:

  • Updated the resourceGroupTags resource in main.bicep to merge existing resource group tags (resourceGroup().tags) with allTags and other custom tags, ensuring that all relevant tags are included.
  • Modified the tags property in main.json to use a shallow merge that now includes resourceGroup().tags, so any pre-existing tags on the resource group are retained in addition to new tags.

Infrastructure and dependency fixes:

  • Fixed the order of dependencies for private DNS zones in main.json by moving the dependency for openAI DNS zone to the correct position in the list.
  • Updated the Bicep-generated template hash in main.json to reflect the changes made.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Kanchan-Microsoft and others added 2 commits October 28, 2025 14:20
fix: Prevent removal of existing RG tags when deploying GSA
feat: Down merge from main to dev
@Roopan-Microsoft Roopan-Microsoft merged commit 908a087 into main Oct 29, 2025
15 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants