fix: Prevent removal of existing RG tags when deploying GSA #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the infrastructure code to enhance tag management for resource groups and corrects the dependency order in the deployment template. The most significant changes are focused on ensuring that resource group tags are properly merged and that dependencies are accurately specified.
Tag Management Improvements:
resourceGroupTagsresource inmain.bicepto merge the existing resource group tags (resourceGroup().tags) withallTags, ensuring all relevant tags are preserved and applied.tagsproperty inmain.jsonto use ashallowMergethat now includesresourceGroup().tagsalong withallTagsand other template-defined tags. This ensures that tags defined at the resource group level are not lost during deployment.Deployment Template and Dependency Fixes:
dependsOnarray inmain.jsonby moving theopenAIprivate DNS zone dependency after theaiServicesandcognitiveServicesDNS zones, ensuring proper resource deployment sequencing.main.jsonto reflect the changes in the infrastructure code.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information