Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@hubuk
Copy link
Contributor

@hubuk hubuk commented May 7, 2015

Recreated missing UpdateManifestVersion console application project. The root cause was a missing exclusion from .gitignore file.
This should fix #34

@sharwell
Copy link
Contributor

❗ I think this should be updated to build the new project as part of the build script, and continue to exclude the compiled binary from source control.

@sharwell
Copy link
Contributor

💡 The build script should not be directly modifying files which live in source control. Eventually this build step will need to be replaced by either a build step that copies the file to the intermediate output directory and applies the transformation there, or moved to be a separate process which is executed to update version numbers on-demand when official releases are made.

@hubuk
Copy link
Contributor Author

hubuk commented Jun 15, 2015

To be closed/modified. Will check if XmlPoke task can be used instead of an executable file.

@hubuk hubuk closed this Jun 17, 2015
@hubuk hubuk reopened this Jun 17, 2015
@hubuk hubuk changed the title Fix for issue #34 Replaced calls to UpdateManifestVersion with XmlPoke Jun 17, 2015
@hubuk
Copy link
Contributor Author

hubuk commented Jun 17, 2015

Should fix issue #34.

Main weaknesses in original approach but not addressed in this PR are:

  1. Version numbers are modified in place. There is no copy-to-temporary-location-and-change approach. This issue should be addressed in Build procedure shall be redefined. #65.
  2. Number of vsixmanifest files should be reduced to one in most optimistic scenario. Probably will be covered in a solution for Code Contract Editor Extensions for VS 2012 crash on start #17 or Build procedure shall be redefined. #65.

@sharwell
Copy link
Contributor

Yes, my solution for the VSIX distribution only uses one vsixmanifest file.

@sharwell
Copy link
Contributor

This is an obviously superior strategy to the previous executable. Good job on that.

My only real question is whether we want to wait for me to finish refactoring the VSIX or not. It shouldn't be too much more work.

@hubuk
Copy link
Contributor Author

hubuk commented Jun 17, 2015

I can surely wait. What would be the best way to do that? Closing this PR for now and reopen it in slightly modified form after your changes?

@sharwell
Copy link
Contributor

That works for me 😄

@hubuk
Copy link
Contributor Author

hubuk commented Jun 17, 2015

Great. I am freezing it for now.

@hubuk hubuk closed this Jun 17, 2015
@mike-barnett
Copy link
Contributor

Thanks so much! This is really great. You are all doing an amazing job getting this code base into shape. I can't tell you how much I appreciate it.

@hubuk hubuk deleted the issue34 branch July 30, 2015 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing UpdateManifestVersion.exe

3 participants