-
Notifications
You must be signed in to change notification settings - Fork 153
Replaced calls to UpdateManifestVersion with XmlPoke #40
Conversation
|
❗ I think this should be updated to build the new project as part of the build script, and continue to exclude the compiled binary from source control. |
|
💡 The build script should not be directly modifying files which live in source control. Eventually this build step will need to be replaced by either a build step that copies the file to the intermediate output directory and applies the transformation there, or moved to be a separate process which is executed to update version numbers on-demand when official releases are made. |
|
To be closed/modified. Will check if XmlPoke task can be used instead of an executable file. |
|
Should fix issue #34. Main weaknesses in original approach but not addressed in this PR are:
|
|
Yes, my solution for the VSIX distribution only uses one vsixmanifest file. |
|
This is an obviously superior strategy to the previous executable. Good job on that. My only real question is whether we want to wait for me to finish refactoring the VSIX or not. It shouldn't be too much more work. |
|
I can surely wait. What would be the best way to do that? Closing this PR for now and reopen it in slightly modified form after your changes? |
|
That works for me 😄 |
|
Great. I am freezing it for now. |
|
Thanks so much! This is really great. You are all doing an amazing job getting this code base into shape. I can't tell you how much I appreciate it. |
Recreated missing UpdateManifestVersion console application project. The root cause was a missing exclusion from .gitignore file.
This should fix #34