Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@billings7
Copy link
Contributor

Partially addresses #18

Full support for 2015 still needs CCI to be updated to support the custom metadata added by the Roslyn compiler when dynamic is used.

@aarondandy
Copy link
Contributor

Is anybody watching this PR with access to upload a new installer?

@VSadov
Copy link
Member

VSadov commented Apr 29, 2015

Re: needs CCI to be updated to support the custom metadata added by the Roslyn

As I understand the most recent version of contract tools should already have updated CCI that has fixes to handle Roslyn outputs. I am not familiar with this codebase though, so I do not know where CCI lives in the tree.

cc @tmat

@billings7
Copy link
Contributor Author

The assemblies in Microsoft.Research\ImportedCCI2 are what needs to be updated. I could do it, however I can't seem to find the source for a few of the assemblies, AsmMeta.exe and Microsoft.Cci.VBSourceEmitter.dll.

@adamvoss
Copy link

adamvoss commented May 1, 2015

With VS2015 having released an RC build, it would be great for a build with this to be released :)

@hubuk
Copy link
Contributor

hubuk commented May 1, 2015

Already recompiled Microsoft.Cci.PdbReader.dll with most recent changes from Codeplex. Commit is pending...

@billings7
Copy link
Contributor Author

I'll have to check if an updated CCI will fix it but I haven't been able to build a project I am working on in 2015, the rewriter fails with some error about not being able to resolve a type.

@hubuk
Copy link
Contributor

hubuk commented May 4, 2015

The error message with type resolving is probably related to Roslyn issue regarding compilation of VisualBasic projects with /nostdlib or /noconfig. I will check it later and raise an issue to Roslyn if confirmed.

@hubuk
Copy link
Contributor

hubuk commented May 7, 2015

👍 Tested on Visual Studio Enterprise 2015 RC. Seems to be working. Great work!

@Daniel-Svensson
Copy link

👍 Installation seems to go fine and code contracts is run as expected under 2015 RC. So a god step on the way to full support for VS 2015

It does seems like it does not rewrite Contracts.Requires(...) inside async methods under VS 2015 (with roslyn) but under VS 2013 it works fine, but that is another problem.

@Daniel-Svensson Daniel-Svensson mentioned this pull request May 8, 2015
@hubuk
Copy link
Contributor

hubuk commented May 13, 2015

Finally diagnosed what was causing errors about not being able to resolve a type. It was a wrong MyType for Microsoft.VisualBasic.Contracts project. Fixed in #43.
Despite some warnings about metadata version compilation under VS2015 shall be working now (with #39 #40 and #43).

@billings7
Copy link
Contributor Author

The problem I have is caused by another issue. I have a solution, just need to get around to do a pull request.
A problem with how type names are parsed in part of the re-writer causes it to fail for certain iterator methods. Will post a full issue soon.

@billings7
Copy link
Contributor Author

I have fixed one problem I was having (#47, pr #48), but that has lead me on to another problem that I currently have no clue how to solve (#49)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to issue #30 this line should point to v14.0 of the targets folder.

@sharwell
Copy link
Contributor

💭 The alternative to this is to distribute the MSBuild tooling exclusively as a NuGet package starting with the Visual Studio 2015 support, and use that as a model for transitioning the older tools as well.

@billings7 billings7 mentioned this pull request Jun 22, 2015
@SergeyTeplyakov
Copy link
Contributor

Guys, what is the current status of this PR?

@billings7
Copy link
Contributor Author

@hubuk suggested that the binary files should not be committed, but be created by part of the build process, which I agree with. However I feel that would be better suited for a different PR, so leave them here for now as they would be a pain for anyone else to built ATM (they were for me anyway) and so we can get an updated setup out ASAP. As long as we are fine with that, this one should be good to go.

SergeyTeplyakov added a commit that referenced this pull request Jul 1, 2015
Additional support for VS2015.
@SergeyTeplyakov
Copy link
Contributor

Merged manually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants