Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Added AutoCollectedMetricsExtractor to processors by default. #646

Merged
cijothomas merged 5 commits into from
Apr 13, 2018
+13 −0
Merged

Added AutoCollectedMetricsExtractor to processors by default. #646

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27997e5
Added AutoCollectedMetricsExtractor to processors by default.
cijothomas Apr 12, 2018
da5f8b1
Merge
cijothomas Apr 12, 2018
f029a15
Merge branch 'develop' into cithomas/addmetricsextractortodefault
cijothomas Apr 12, 2018
ce156e1
Merge from dev
cijothomas Apr 12, 2018
fb9e9bb
Merge branch 'cithomas/addmetricsextractortodefault' of https://githu…
cijothomas Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- [TelemetryChannel is configured via DI, making it easier to override channel](https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/641)
- [Fixed a bug which caused QuickPulse and Sampling to be enabled only if ServerTelemetryChannel was used](https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/642)
- [QuickPulseTelemetryModule is constructed via DI, make it possible for users to configure it.] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/639)
- [AutocollectedMetricsExtractor is added by default to the TelemetryConfiguration](https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/604)

## Version 2.2.1
- Updated Web/Base SDK version dependency to 2.5.1 which addresses a bug.
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public static IServiceCollection AddApplicationInsightsTelemetry(this IServiceCo
services.AddSingleton<ITelemetryInitializer, AspNetCoreEnvironmentTelemetryInitializer>();
services.AddSingleton<ITelemetryInitializer, HttpDependenciesParsingTelemetryInitializer>();
services.TryAddSingleton<ITelemetryChannel, ServerTelemetryChannel>();
services.AddApplicationInsightsTelemetryProcessor<AutocollectedMetricsExtractor>();
services.AddSingleton<ITelemetryModule, DependencyTrackingTelemetryModule>();
services.ConfigureTelemetryModule<DependencyTrackingTelemetryModule>((module) => {
var excludedDomains = module.ExcludeComponentCorrelationHttpHeadersOnDomains;
Expand Down
11 changes: 11 additions & 0 deletions ...oft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,17 @@ public static void AddsQuickPulseProcessorToTheConfigurationByDefault()
Assert.Equal(1, qpProcessorCount);
}

[Fact]
public static void AddsAutoCollectedMetricsExtractorProcessorToTheConfigurationByDefault()
Copy link
Copy Markdown
Member

@Dmitry-Matveev Dmitry-Matveev Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any test actually confirming it's operational after it has been added? Or we're OK it's covered in the other repos?

Copy link
Copy Markdown
Contributor Author

@cijothomas cijothomas Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo simply does the configuratin i.e ensure the processor is added. Its coming from base sdk and tested there. (same is followed for pretty much everything in this repo like DepCollector/perfCollector. etc)

{
var services = CreateServicesAndAddApplicationinsightsTelemetry(null, "http://localhost:1234/v2/track/", null, false);
services.AddSingleton<ITelemetryChannel, InMemoryChannel>();
IServiceProvider serviceProvider = services.BuildServiceProvider();
var telemetryConfiguration = serviceProvider.GetTelemetryConfiguration();
var metricExtractorProcessorCount = GetTelemetryProcessorsCountInConfiguration<AutocollectedMetricsExtractor>(telemetryConfiguration);
Assert.Equal(1, metricExtractorProcessorCount);
}

[Fact]
public static void DoesNotAddQuickPulseProcessorToConfigurationIfExplicitlyControlledThroughParameter()
{
Expand Down