This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Added AutoCollectedMetricsExtractor to processors by default.#646
Merged
cijothomas merged 5 commits intodevelopfrom Apr 13, 2018
Merged
Added AutoCollectedMetricsExtractor to processors by default.#646cijothomas merged 5 commits intodevelopfrom
cijothomas merged 5 commits intodevelopfrom
Conversation
…b.com/Microsoft/ApplicationInsights-aspnetcore into cithomas/addmetricsextractortodefault
TimothyMothra
approved these changes
Apr 12, 2018
Dmitry-Matveev
approved these changes
Apr 13, 2018
| } | ||
|
|
||
| [Fact] | ||
| public static void AddsAutoCollectedMetricsExtractorProcessorToTheConfigurationByDefault() |
Member
There was a problem hiding this comment.
Do we need any test actually confirming it's operational after it has been added? Or we're OK it's covered in the other repos?
Contributor
Author
There was a problem hiding this comment.
This repo simply does the configuratin i.e ensure the processor is added. Its coming from base sdk and tested there. (same is followed for pretty much everything in this repo like DepCollector/perfCollector. etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #604
This makes Asp.Net Core and Classic Asp.Net apps to have consistent behavior and makes ApplicationInsights Portal UI faster for metrics.
For significant contributions please make sure you have completed the following items:
Changes in public surface reviewed
Design discussion issue #
CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.