Bump com.dynatrace.metric.util:dynatrace-metric-utils-java from 2.3.0 to 2.4.0 #6739
Conversation
Bumps [com.dynatrace.metric.util:dynatrace-metric-utils-java](https://github.com/dynatrace-oss/dynatrace-metric-utils-java) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/dynatrace-oss/dynatrace-metric-utils-java/releases) - [Commits](dynatrace-oss/dynatrace-metric-utils-java@v2.3.0...v2.4.0) --- updated-dependencies: - dependency-name: com.dynatrace.metric.util:dynatrace-metric-utils-java dependency-version: 2.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
It seems metadata serialization has changed in dynatrace-metric-utils-java:2.4.0. In 2.3.0 and before: '#my.count count dt.meta.description=count\ description,dt.meta.unit=Bytes' In 2.4.0: '#my.count count dt.meta.description="count description",dt.meta.unit=Bytes' See dynatrace-oss/dynatrace-metric-utils-java#43
|
@pirgeo Could you please confirm that the changed metadata serialization in dynatrace-oss/dynatrace-metric-utils-java#43 will not cause issues for users who send the data in the new format to an older Dynatrace component? |
dependabot
bot
deleted the
dependabot/gradle/main/com.dynatrace.metric.util-dynatrace-metric-utils-java-2.4.0
branch
|
@jonatan-ivanov Confirmed. This bug exclusively affected display name and description for new metrics. No dashboards, alerts, or other stored queries will be impacted (the metric names or attributes won't change). |
|
We try to follow semver so in minor versions (1.15 -> 1.16) we usually introduce minor version bumps of dependencies (2.3 -> 2.4) and keep patch versions (1.15.1 -> 1.15.2) for patch version bumps and bugfixes. Though, based on what you are saying, the normalization change was a bugfix(?) and it seems 2.4.0 did not contain any other changes. We can consider it for back-porting but could you please tell why wasn't this released as 2.3.1? Also, if you would consider it releasing as 2.3.1? |
|
Oh, sorry, correction: Micrometer
I'm not sure about these changes, if they can be back-ported to Micrometer |
|
Oh, I got it. The MD5 change was neither a bug nor a feature, we changed it because the use of MD5 was flagged as a security vulnerability, and that is true if we used it for encryption, but we just use it to see if a file changed. That's why CRC32 is fine in that application. It didn't feel like a bugfix, and it isn't urgent, so we released it as minor version. The change in dynatrace-oss/dynatrace-metric-utils-java#43 is definitely closer to a bugfix but it's unrelated to the previous change. I'll look into releasing that as a patch version instead, maybe 2.2.2. Thanks for explaining the way you use versioning, it makes total sense! |
Bumps com.dynatrace.metric.util:dynatrace-metric-utils-java from 2.3.0 to 2.4.0.
Release notes
Sourced from com.dynatrace.metric.util:dynatrace-metric-utils-java's releases.
Commits
6bdac98fix metadata normalization (#43)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)