Swap MD5 hash to CRC32 for checksum calculation #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
reviewed
Jan 17, 2025
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Overall looks good, just one comment I'm not sure about.
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
pichlermarc
reviewed
Jan 21, 2025
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
joaopgrassi
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this use-case, use of a cryptographic hash function is not required. File contents are being hashed and compared to identify whether a change in the file occurred.