Skip to content

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Apr 10, 2024

This PR changes to support @MeterTag for @Counted.

Closes gh-4725

@shakuzen
Copy link
Member

Thanks for the pull request. We'll review once we've branched 1.13.x since this is targeted for 1.14.0-M1 but main is still on 1.13

@shakuzen shakuzen added the blocked An issue that's blocked on an external project change label Apr 22, 2024
@shakuzen shakuzen removed the blocked An issue that's blocked on an external project change label May 14, 2024
@jonatan-ivanov jonatan-ivanov added enhancement A general enhancement module: micrometer-core An issue that is related to our core module and removed enhancement A general enhancement module: micrometer-core An issue that is related to our core module labels Jun 21, 2024
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@shakuzen shakuzen merged commit 58f429d into micrometer-metrics:main Jul 4, 2024
@izeye izeye deleted the gh-4725 branch July 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add Support for @MeterTag to @Counted

3 participants