Using a metric annotation with dynamic tags (@Timed and @Counter)

[afishler]

When creating metrics via annotations like @timed and @counter it is possible to inject static common tags.

However, there doesn't seem to be a way to add tags upon method execution as tags can be dynamic and change from request to request.

Or maybe there is one and I am missing it?

ability to add the tags seems to be in code - but not through the annotations.

[afishler]

Is this solved by #1732?

[jonatan-ivanov]

Shortly: yes.
There might be still things were you need to do things manually, e.g.: local variables but that should not be too hard most of the times, e.g.: timer.record(this::doSomething).

Please look into the docs of @Timed, you might find what you need there.

[borisstarik]

Hi Jonatan . This issue was opens for our use case. We are want to use micrometer in our product. And we are have some limitation. Because we are working in multi tenancy model , some of tags will be dynamically assigned per request( for example taenant_id) In lot of cases we are want to use @timed and @counted annotation .
And we are was think about the possibility to obtaining some of tags dynamically
For example

@tymed(value="someVlue",description = "someDescription",extraTagsKeys = {"tenant_id","execution_id"},tagsValueResolver=MyClassResolver.class)
public void myMethod{}
Also for @counted

BTW, I was implemented it for my test and it's works , but the problem is - I was override the original annotation and aspect code and we are thinking it's will be problematic when we will need to upgrade the library to the next version.
As I see in the questions , I think this feature will be very useful for all community which works with micrometer library.

[shakuzen]

Could you please explain more specifically why you can't use the feature delivered in #1732 for your use case?

[borisstarik]

Hi ! Thanks for quick response.
I am familiar with solution of [#1732 ] it's @MetricTag annotation. This annotation working on method parameter.
I was implemented it into my POC its may works but I am using it only for interrupt the previous annotation and assume dynamic tags values into timer. I am not looking the tag values or tag names in method parameters.
This is the first part of the problem.
The second part that it's not implemented for @counter.
And I want to take to developers possibility in minimum code and minimum human errors implement @timed and @counter in our application.
Thanks !

[shakuzen]

This annotation working on method parameter.

Do you mean you are getting tag values from somewhere other than method parameters? If so, where are the values coming from?

[borisstarik]

Yes . Correct. I am getting it from ThreadLocal. It's our custom implementation ,some wrapper for thread local that holds also tenant_id. And on each request it's may be deferent teanant_id

[jonatan-ivanov]

We don't have that functionality right now, could you please take a look at this and check if the proposal/PoC could work work for you? #1586

[borisstarik]

Thanks for response. I was checked #1586. It's partially works only for @timed

[msewerniak]

Is anyone working on making @MetricTag working for @counted ?

[izeye]

@msewerniak If you meant to ask about @MeterTag, see #4725 and #4958.