-
Notifications
You must be signed in to change notification settings - Fork 33
https://github.com/microbiome/OMA/issues/824 #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xMuluh
wants to merge
8
commits into
devel
Choose a base branch
from
mds
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
55ae63d
update mia_logo (#784)
0xMuluh ae00b7a
Fixes issue 767 (#793)
TuomasBorman 6b23983
:memo: docs: add vegan 2.7-1 requirement for rCLR and rAitchison (#758)
mm-hak c57393f
Fix typos in documentation for Double Principal Correspondence analys…
hindrek 96cf847
https://github.com/microbiome/OMA/issues/824
0xMuluh c0c816f
Merge branch 'devel' into mds
0xMuluh 901f83a
Merge branch 'devel' into mds
antagomir 241e955
Merge branch 'devel' into mds
antagomir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the R code throw a warning of this if it does not use all features? (if data has more than 500)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have
mia::getMDSandmia::addMDS, we could set the default to no filtering. At least, I have not heard that variance filtering is commonly used in MDS in microbiome context (or then authors of papers have not explicitly stated that)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would also set the default to no filtering.
We can show examples on how to add filtering.