Skip to content

Removed proxies arg from translation request#31

Merged
mhbuehler merged 7 commits intommqna-audio-queryfrom
omar/move-gateway
Dec 10, 2024
Merged

Removed proxies arg from translation request#31
mhbuehler merged 7 commits intommqna-audio-queryfrom
omar/move-gateway

Conversation

@okhleif-10
Copy link
Copy Markdown
Collaborator

@okhleif-10 okhleif-10 commented Dec 10, 2024

Description

Removed proxies arg from translation request

Issues

Addressing a comment from https://github.com/opea-project/GenAIComps/pull/974/files#

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

N/A

Copy link
Copy Markdown
Owner

@mhbuehler mhbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my tests are passing, LGTM!

@mhbuehler mhbuehler merged commit 31da576 into mmqna-audio-query Dec 10, 2024
@mhbuehler mhbuehler deleted the omar/move-gateway branch December 10, 2024 22:54
dmsuehir added a commit that referenced this pull request Dec 16, 2024
* Add var for LVM model

Signed-off-by: dmsuehir <[email protected]>

* README updates and tests

Signed-off-by: dmsuehir <[email protected]>

* Build, compose, and doc updates for audio query (#12)

Signed-off-by: okhleif-IL <[email protected]>

* validated, updated tests

Signed-off-by: okhleif-IL <[email protected]>

* added one more curl test for audio

Signed-off-by: okhleif-IL <[email protected]>

* fixed typo

Signed-off-by: okhleif-IL <[email protected]>

* reverted git clone command

Signed-off-by: okhleif-IL <[email protected]>

* added ASR test

Signed-off-by: okhleif-IL <[email protected]>

* fixed command with backslashes

Signed-off-by: okhleif-IL <[email protected]>

---------

Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: dmsuehir <[email protected]>

* MMQnA doc update correcting ASR and whisper image names (#24)

* MMQnA doc update correcting ASR and whisper image names

Signed-off-by: dmsuehir <[email protected]>

* Add image tags

Signed-off-by: dmsuehir <[email protected]>

---------

Signed-off-by: dmsuehir <[email protected]>

* Integrate audio query into UI (#22)

* Enabled audio query functionality in the MultimodalQnA UI

Signed-off-by: Melanie Buehler <[email protected]>

* Temporarily redirect clones for tests

Signed-off-by: Melanie Buehler <[email protected]>

* Doc update and set MAX_IMAGES to default to 1 in compose.yaml

Signed-off-by: dmsuehir <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* README update to add a note about MAX_IMAGES

Signed-off-by: dmsuehir <[email protected]>

* Add services to tests and correct small text error (#26)

* Add services to tests and correct small text error

Signed-off-by: Melanie Buehler <[email protected]>

* Revert unintended changes

Signed-off-by: Melanie Buehler <[email protected]>

---------

Signed-off-by: Melanie Buehler <[email protected]>

* Fixed build.yaml inconsistency

Signed-off-by: Melanie Buehler <[email protected]>

* Moving note about MAX_IMAGES due to review feedback:

Signed-off-by: dmsuehir <[email protected]>

* Update repo clones for E2E tests

Signed-off-by: Melanie Buehler <[email protected]>

* Moved Audio Query Gateway changes to multimodalqna.py (#29)

* Moved gateway changes to multimodalqna.py

Signed-off-by: okhleif-IL <[email protected]>

* reverted port changes

Signed-off-by: okhleif-IL <[email protected]>

* addressed review comments

Signed-off-by: okhleif-IL <[email protected]>

* reverted print statement

Signed-off-by: okhleif-IL <[email protected]>

---------

Signed-off-by: okhleif-IL <[email protected]>

* Removed proxies arg from translation request (#31)

* Moved gateway changes to multimodalqna.py

Signed-off-by: okhleif-IL <[email protected]>

* reverted port changes

Signed-off-by: okhleif-IL <[email protected]>

* addressed review comments

Signed-off-by: okhleif-IL <[email protected]>

* reverted print statement

Signed-off-by: okhleif-IL <[email protected]>

* removed proxies

Signed-off-by: okhleif-IL <[email protected]>

---------

Signed-off-by: okhleif-IL <[email protected]>

* Add MAX_IMAGES to docs

Signed-off-by: dmsuehir <[email protected]>

* Moved gateway updates for image query to GenAIExamples

Signed-off-by: dmsuehir <[email protected]>

* Fix initial input format for TextImageDoc

Signed-off-by: dmsuehir <[email protected]>

* Fix merge conflict

Signed-off-by: dmsuehir <[email protected]>

* Fix merge conflict

Signed-off-by: dmsuehir <[email protected]>

* Add Gaudi tests

Signed-off-by: dmsuehir <[email protected]>

* Temporary update to use dev branch for test

Signed-off-by: dmsuehir <[email protected]>

* Temporary change for dockerfile to use dev fork/branch for GenAIComps

Signed-off-by: dmsuehir <[email protected]>

---------

Signed-off-by: dmsuehir <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Co-authored-by: Omar Khleif <[email protected]>
Co-authored-by: Melanie Hart Buehler <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Abolfazl Shahbazi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants