Moved Audio Query Gateway changes to multimodalqna.py#29
Merged
mhbuehler merged 5 commits intommqna-audio-queryfrom Dec 10, 2024
Merged
Moved Audio Query Gateway changes to multimodalqna.py#29mhbuehler merged 5 commits intommqna-audio-queryfrom
mhbuehler merged 5 commits intommqna-audio-queryfrom
Conversation
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
requested changes
Dec 9, 2024
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
approved these changes
Dec 9, 2024
Collaborator
dmsuehir
left a comment
dmsuehir
left a comment
There was a problem hiding this comment.
LGTM as long as it's tested and working.
mhbuehler
approved these changes
Dec 9, 2024
dmsuehir
added a commit
that referenced
this pull request
Dec 16, 2024
* Add var for LVM model Signed-off-by: dmsuehir <[email protected]> * README updates and tests Signed-off-by: dmsuehir <[email protected]> * Build, compose, and doc updates for audio query (#12) Signed-off-by: okhleif-IL <[email protected]> * validated, updated tests Signed-off-by: okhleif-IL <[email protected]> * added one more curl test for audio Signed-off-by: okhleif-IL <[email protected]> * fixed typo Signed-off-by: okhleif-IL <[email protected]> * reverted git clone command Signed-off-by: okhleif-IL <[email protected]> * added ASR test Signed-off-by: okhleif-IL <[email protected]> * fixed command with backslashes Signed-off-by: okhleif-IL <[email protected]> --------- Signed-off-by: Melanie Buehler <[email protected]> Signed-off-by: okhleif-IL <[email protected]> Signed-off-by: dmsuehir <[email protected]> * MMQnA doc update correcting ASR and whisper image names (#24) * MMQnA doc update correcting ASR and whisper image names Signed-off-by: dmsuehir <[email protected]> * Add image tags Signed-off-by: dmsuehir <[email protected]> --------- Signed-off-by: dmsuehir <[email protected]> * Integrate audio query into UI (#22) * Enabled audio query functionality in the MultimodalQnA UI Signed-off-by: Melanie Buehler <[email protected]> * Temporarily redirect clones for tests Signed-off-by: Melanie Buehler <[email protected]> * Doc update and set MAX_IMAGES to default to 1 in compose.yaml Signed-off-by: dmsuehir <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * README update to add a note about MAX_IMAGES Signed-off-by: dmsuehir <[email protected]> * Add services to tests and correct small text error (#26) * Add services to tests and correct small text error Signed-off-by: Melanie Buehler <[email protected]> * Revert unintended changes Signed-off-by: Melanie Buehler <[email protected]> --------- Signed-off-by: Melanie Buehler <[email protected]> * Fixed build.yaml inconsistency Signed-off-by: Melanie Buehler <[email protected]> * Moving note about MAX_IMAGES due to review feedback: Signed-off-by: dmsuehir <[email protected]> * Update repo clones for E2E tests Signed-off-by: Melanie Buehler <[email protected]> * Moved Audio Query Gateway changes to multimodalqna.py (#29) * Moved gateway changes to multimodalqna.py Signed-off-by: okhleif-IL <[email protected]> * reverted port changes Signed-off-by: okhleif-IL <[email protected]> * addressed review comments Signed-off-by: okhleif-IL <[email protected]> * reverted print statement Signed-off-by: okhleif-IL <[email protected]> --------- Signed-off-by: okhleif-IL <[email protected]> * Removed proxies arg from translation request (#31) * Moved gateway changes to multimodalqna.py Signed-off-by: okhleif-IL <[email protected]> * reverted port changes Signed-off-by: okhleif-IL <[email protected]> * addressed review comments Signed-off-by: okhleif-IL <[email protected]> * reverted print statement Signed-off-by: okhleif-IL <[email protected]> * removed proxies Signed-off-by: okhleif-IL <[email protected]> --------- Signed-off-by: okhleif-IL <[email protected]> * Add MAX_IMAGES to docs Signed-off-by: dmsuehir <[email protected]> * Moved gateway updates for image query to GenAIExamples Signed-off-by: dmsuehir <[email protected]> * Fix initial input format for TextImageDoc Signed-off-by: dmsuehir <[email protected]> * Fix merge conflict Signed-off-by: dmsuehir <[email protected]> * Fix merge conflict Signed-off-by: dmsuehir <[email protected]> * Add Gaudi tests Signed-off-by: dmsuehir <[email protected]> * Temporary update to use dev branch for test Signed-off-by: dmsuehir <[email protected]> * Temporary change for dockerfile to use dev fork/branch for GenAIComps Signed-off-by: dmsuehir <[email protected]> --------- Signed-off-by: dmsuehir <[email protected]> Signed-off-by: Melanie Buehler <[email protected]> Signed-off-by: okhleif-IL <[email protected]> Co-authored-by: Omar Khleif <[email protected]> Co-authored-by: Melanie Hart Buehler <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Abolfazl Shahbazi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves our gateway changes from this PR to the multimodalqna.py file in GenAIExamples
Issues
Original PR link opea-project/GenAIComps#974
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
None