Use CMAKE_STATIC_LIBRARY_* macros for FindRdKafka #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, library suffixes are hard coded from a hand-maintained list. Instead of writing this list, we can use the CMake macros for platform specific library prefix/suffixes. E.g. https://cmake.org/cmake/help/v3.0/variable/CMAKE_STATIC_LIBRARY_SUFFIX.html This also resolves library resolution on Mac OSX, which does not currently work on the native `.dylib` suffix for shared libraries.
accelerated
reviewed
Jan 13, 2019
Contributor
accelerated
left a comment
accelerated
left a comment
There was a problem hiding this comment.
I wonder if this breaks previous PR
Contributor
Author
|
I don't think it should, because it has the same search order as before
(specific filename before general filename).
It's been working fine when doing static linking for me, but of course I
would welcome other testers.
|
Owner
|
Nice, I didn't know those existed. I don't think this should break anything, it should be equivalent while also working in cases like OSX. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, library suffixes are hard coded from a hand-maintained list. Instead of writing this list, we can use the CMake macros for platform specific library prefix/suffixes.
E.g. https://cmake.org/cmake/help/v3.0/variable/CMAKE_STATIC_LIBRARY_SUFFIX.html
This also resolves library resolution on Mac OSX, which does not currently work on the native
.dylibsuffix for shared libraries.