Specific linking option for rdkafka library#94
Merged
mfontanini merged 1 commit intomfontanini:masterfrom Jun 25, 2018
Merged
Conversation
accelerated
force-pushed
the
rdkafka_static_linking
branch
from
5438ff4 to
b20eada
Compare
accelerated
force-pushed
the
rdkafka_static_linking
branch
from
b20eada to
19d750a
Compare
Contributor
Author
|
@mfontanini Hi, would it be possible to review the PRs I submitted? They're quite straightforward. The main ones are this one and the pause/resume. The others can wait but ideally if you can wrap them up it would be nice. Thanks! |
Owner
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives an option at build time to statically or dynamically link the rdkafka library. The issue is that if both .a and .so files are present in the same directory (or .lib and .dll for windows), cmake seems to prefer the shared library by default. The only way to control this is to force
find_pathto look for more specific names first and then the more generic names (without a suffix) afterward.If
.a .so .lib and .dllfiles are not there, the default cmake search pattern will be used.