Skip to content

MBS-14050: Add tests for find_best_primary_alias #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reosarevok wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MBS-14050: Add tests for find_best_primary_alias #3556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 93 additions & 0 deletions t/lib/t/MusicBrainz/Server/Data/Utils.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ use Test::Fatal;
use MusicBrainz::Server::Context;
use MusicBrainz::Server::Data::Utils qw(
order_by
find_best_primary_alias
generate_gid
take_while
sanitize
trim
ref_to_type
model_to_type
);
use MusicBrainz::Server::Entity::Alias;
use MusicBrainz::Server::Entity::AreaAliasType;
use MusicBrainz::Server::Entity::PartialDate;
use MusicBrainz::Server::Entity::Recording;
Expand Down Expand Up @@ -250,4 +252,95 @@ test 'Test model_to_type' => sub {
'model_to_type of "URL" is "url"');
};


test 'Test find_best_primary_alias' => sub {
my @aliases = (
MusicBrainz::Server::Entity::Alias->new(
name => 'Alias McAliasy',
sort_name => 'McAliasy, Alias',
locale => 'en_US',
primary_for_locale => 1,
),
MusicBrainz::Server::Entity::Alias->new(
name => 'Alias von Alias',
sort_name => 'Alias, Alias von',
locale => 'de',
primary_for_locale => 1,
),
MusicBrainz::Server::Entity::Alias->new(
name => 'Alias von der Schweiz',
sort_name => 'Schweiz, Alias von der',
locale => 'de_CH',
primary_for_locale => 1,
),
MusicBrainz::Server::Entity::Alias->new(
name => 'Alias van der Alias',
sort_name => 'van der Alias, Alias',
locale => 'nl',
primary_for_locale => 0,
),
MusicBrainz::Server::Entity::Alias->new(
name => 'Alias de Alias y Alias',
sort_name => 'Alias y Alias, Alias de',
locale => 'es',
ended => 1,
primary_for_locale => 1,
),
);

is(
find_best_primary_alias(\@aliases, 'de')->name,
'Alias von Alias',
'Asking for "de" alias, "de" match is returned',
);

is(
find_best_primary_alias(\@aliases, 'de_CH')->name,
'Alias von der Schweiz',
'Asking for "de_CH" alias, "de_CH" match is returned',
);

is(
find_best_primary_alias(\@aliases, 'de_AT')->name,
'Alias von Alias',
'Asking for "de_AT" alias, "de" fallback is returned since we lack "de_AT"',
);

is(
find_best_primary_alias(\@aliases, 'en')->name,
'Alias McAliasy',
'Asking for "en" alias, "en" match is returned',
);

is(
find_best_primary_alias(\@aliases, 'nl')->name,
'Alias McAliasy',
'Asking for "nl" alias, "en" fallback is returned since "nl" is not primary',
);

is(
find_best_primary_alias(\@aliases, 'es')->name,
'Alias McAliasy',
'Asking for "es" alias, "en" fallback is returned since "es" is ended',
);

is(
find_best_primary_alias(\@aliases, 'es_AR')->name,
'Alias McAliasy',
'Asking for "es_AR" alias, "en" fallback is returned since "es" fallback is ended',
);

is(
find_best_primary_alias(\@aliases, 'it')->name,
'Alias McAliasy',
'Asking for "it" alias, "en" fallback is returned since we lack "it"',
);

is(
find_best_primary_alias([], 'en'),
undef,
'Nothing is returned if no aliases exist',
);
};

1;
Loading