MBS-14050: Add tests for find_best_primary_alias#3556
Open
reosarevok wants to merge 1 commit intometabrainz:masterfrom
Open
MBS-14050: Add tests for find_best_primary_alias#3556reosarevok wants to merge 1 commit intometabrainz:masterfrom
reosarevok wants to merge 1 commit intometabrainz:masterfrom
Conversation
Contributor
|
Nice! It might be worthwhile passing different alias lists to test what happens when there are no primary aliases at all, e.g.
(Maybe those are already covered by the existing "no aliases" case if the code starts by filtering out all non-primary aliases, though.) Might also be worth testing what happens when there's no English primary alias to fall back to, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MBS-14050
Description
I think I covered all the main cases here: exact locale match, fallback to language default, fallback to English, skipping non-primary aliases, skipping ended aliases. Happy to add more cases if I missed something :)