Skip to content

nit: remove (nightly) in recipes #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebsmothers merged 6 commits into from
Oct 26, 2024
Merged

nit: remove (nightly) in recipes #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0c3156
just nit 405B_qlora.yaml
krammnic Oct 22, 2024
bc3d0ef
just nit 70B_full.yaml
krammnic Oct 22, 2024
a6a501f
Update 70B_full.yaml
krammnic Oct 22, 2024
64b5bb8
Update 70B_full.yaml
krammnic Oct 23, 2024
ff59d4a
Update 405B_qlora.yaml
krammnic Oct 23, 2024
61393e8
Update 70B_full.yaml
krammnic Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions recipes/configs/llama3/70B_full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@
#
# This config is only tested on an 8xA100 machine.
#
# !!!!!!!!!!!!!
# !!!!!!!!!!!!!
# ATTENTION: It will only work with pytorch>=2.5 (nightlies). For other pytorch versions, it will OOM, even on 8xA100.
Copy link
Member

@joecummings joecummings Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this all together. We make no guarantees to really support any versions of PyTorch with the exception of the latest PyTorch and nightlies.

Copy link
Collaborator Author

@krammnic krammnic Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

# !!!!!!!!!!!!!
# !!!!!!!!!!!!!


# Tokenizer
Expand Down
6 changes: 1 addition & 5 deletions recipes/configs/llama3_1/405B_qlora.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@
# This config needs 8 GPUs to run
# # tune run --nproc_per_node 8 lora_finetune_distributed --config llama3_1/405B_qlora
#
# !!!!!!!!!!!!!
# !!!!!!!!!!!!!
# ATTENTION: It will only work with pytorch>=2.5 (nightlies). For other pytorch versions, it will OOM, even on 8xA100.
# !!!!!!!!!!!!!
# !!!!!!!!!!!!!


# Model Arguments
model:
Expand Down
5 changes: 0 additions & 5 deletions recipes/configs/llama3_1/70B_full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@
#
# This config is only tested on an 8xA100 machine.
#
# !!!!!!!!!!!!!
# !!!!!!!!!!!!!
# ATTENTION: It will only work with pytorch>=2.5 (nightlies). For other pytorch versions, it will OOM, even on 8xA100.
# !!!!!!!!!!!!!
# !!!!!!!!!!!!!

# Tokenizer
tokenizer:
Expand Down