nit: remove (nightly) in recipes #1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1882
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 61393e8 with merge base ca37c59 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
krammnic
changed the title
joecummings
reviewed
Oct 23, 2024
| # | ||
| # !!!!!!!!!!!!! | ||
| # !!!!!!!!!!!!! | ||
| # ATTENTION: It will only work with pytorch>=2.5 (nightlies). For other pytorch versions, it will OOM, even on 8xA100. |
Member
There was a problem hiding this comment.
I think we can remove this all together. We make no guarantees to really support any versions of PyTorch with the exception of the latest PyTorch and nightlies.
ebsmothers
approved these changes
Oct 25, 2024
Contributor
ebsmothers
left a comment
ebsmothers
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
*
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example
Just fix nit as 2.5.0 is out, we do not require to use unstable nightlies for Llama3 70B, Llama3.1 70B, 405B. Discussed offline