Skip to content

vulkan-headers: update from 1.3.283 to 1.4.345#2690

Open
silvanshade wants to merge 1 commit intomesonbuild:masterfrom
silvanshade:Vulkan-Headers-1.4.345
Open

vulkan-headers: update from 1.3.283 to 1.4.345#2690
silvanshade wants to merge 1 commit intomesonbuild:masterfrom
silvanshade:Vulkan-Headers-1.4.345

Conversation

@silvanshade
Copy link

No description provided.

@neheb neheb requested review from bgilbert and eli-schwartz March 10, 2026 22:31
@neheb
Copy link
Collaborator

neheb commented Mar 10, 2026

Per CMake, the dependency would be VulkanHeaders

Not sure how to handle this though. Nothing uses it.

@bgilbert
Copy link
Collaborator

Code changes LGTM.

In the past, when I've found incorrect dependency names, I've just fixed them. The dependency will cleanly break when the wrap is updated downstream, at which point downstream can fix its dependency() call.

We could of course provide both names, but then that would continue forever unless we eventually decide to do the break after all.

@silvanshade
Copy link
Author

@neheb @bgilbert Can you be concrete about the changes you want?

Are you asking me to modify it like this?

meson.override_dependency('VulkanHeaders', vulkan_headers_dep)

and this?

dependency_names = VulkanHeaders

What about the corresponding part in releases.json?

  "vulkan-headers": {
    "dependency_names": [
      "vulkanheaders"
    ],
    "versions": [
      "1.4.345-1",

It's not clear to me what is supposed to be changed there.

Do I just add "VulkanHeaders" as a new entry under "dependency_names" (in order to avoid breakage with earlier versions) or something else? Create a new top-level entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants