Dynamically update reported Vulkan present mode#1988
Merged
flightlessmango merged 2 commits intoflightlessmango:masterfrom Mar 15, 2026
Merged
Conversation
This commit uses a local wrap for vulkan-headers 1.4.345 corresponding to an upstream PR for wrapdb which is not yet merged.
This fixes an issue where if an application used swapchain maintenance to update the present mode, it would not be reflected correctly by the present mode reported by the overlay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
overlay_QueuePresentKHRto read the present mode associated with the swapchain.This allows to detect when the present mode has been changed dynamically when using swapchain maintenance.
This fixes the problem where the present mode reported for
vkd3d-protonis often incorrect, for example if vsync is switched off after the application is started.This PR also includes a local wrap for updated Vulkan headers pending an upstream PR
Related issues: