vulkan-headers: update from 1.3.283 to 1.4.345#2690
Open
silvanshade wants to merge 1 commit intomesonbuild:masterfrom
Open
vulkan-headers: update from 1.3.283 to 1.4.345#2690silvanshade wants to merge 1 commit intomesonbuild:masterfrom
silvanshade wants to merge 1 commit intomesonbuild:masterfrom
Conversation
Collaborator
|
Per CMake, the dependency would be VulkanHeaders Not sure how to handle this though. Nothing uses it. |
Collaborator
|
Code changes LGTM. In the past, when I've found incorrect dependency names, I've just fixed them. The dependency will cleanly break when the wrap is updated downstream, at which point downstream can fix its We could of course provide both names, but then that would continue forever unless we eventually decide to do the break after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.