[melange.ppx]: move the entire PPX frontend to melange.ppx by anmonteiro · Pull Request #583 · melange-re/melange

anmonteiro · 2023-05-19T00:44:04Z

This change moves pipe-first (foo |. bar / foo->bar) to melange.ppx
It also shows how we can incrementally migrate features off of jscomp/frontend to the melange ppx

fixes #568

changes:
- removes bs.deriving {abstract,accessors,jsConverter} in favor of deriving {abstract,accessors,jsConverter}
  - stops supporting the bs.deriving form
- [@@deriving abstract]:
  - no longer creates a new, abstract type.
  - requires [@bs.optional] types to be annotated with option explicitly.
    - This makes the non-abstract type compatible with the record due to advances in the runtime representation since both were introduced. This effectively unifies the record + <..> Js.t representation for @@deriving abstract.
    - it's also a breaking change that will require changes in some libraries (including reason-react)
- converts "unused attribute" warnings into errors in the PPX. this makes the FFI a lot stricter.

jchavarri

❤️

jchavarri · 2023-05-22T06:15:34Z

jscomp/test/derive_projector_test.ml


-type xx = < x : int > Js.t
-[@@bs.deriving accessors]
+(* Not applicable to this type. *)


What happens if the deriving attribute is applied to an invalid type? Unused warning, right?

jchavarri · 2023-05-22T06:16:19Z

jscomp/core/lam_compile_external_obj.ml

        match acc with
        | Splice2 _ | Splice0 -> assert false
        | Splice1 x ->
-            ((Js_op.Lit label, x) :: accs, Ext_list.append new_eff eff, assign)


Is the goal to get rid of Ext_list?

I regret doing this mixed with the other changes, but I removed some functions that existed in List. for the OCaml versions that we support.

jchavarri · 2023-05-22T06:20:34Z

test/unused-attributes.t

+  // Generated by Melange
+  /* This output is empty. Its source's type definitions, externals and/or unused code got optimized away. */


It is a bit strange to include this in the error output. I understand it is caused by the hack to preserve melc behavior to avoid adding -ppx melppx to dune?

CHANGES: - Build executables for bytecode-only platforms too ([melange-re/melange#596](melange-re/melange#596)) - Move the entire builtin PPX to `melange.ppx`. Preprocessing with `melange.ppx` will needed in most cases going forward, as it's responsible for processing `external` declarations, `@deriving` attributes and more, compared to the previous release where `melange.ppx` just processed AST extension nodes ([melange-re/melange#583](melange-re/melange#583)) - Remove old BuckleScript-style conditional compilation ([melange-re/melange#605](melange-re/melange#605)) - Don't emit JS import / require paths with `foo/./bar.js` ([melange-re/melange#598](melange-re/melange#598), [melange-re/melange#612](melange-re/melange#612)) - Wrap the melange runtime ([melange-re/melange#624](melange-re/melange#624), [melange-re/melange#637](melange-re/melange#637)). After this change, Melange exposes fewer toplevel modules. Melange runtime / stdlib modules are now wrapped under: - `Caml*` / `Curry` modules are part of the runtime and keep being exposed as before - `Js.*` contains all the modules previously accessible via `Js_*`, e.g. `Js_int` -> `Js.Int` - `Belt.*` wraps all the `Belt` modules; `Belt_List` etc. are not exposed anymore, but rather nested under `Belt`, e.g. `Belt.List` - `Node.*`: we now ship a `melange.node` library that includes the modules containing Node.js bindings. After this change, users will have to depend on `melange.node` explicitly in order to use the `Node.*` modules - `Dom.*`: we now ship a `melange.dom` library that includes the modules containing Node.js bindings. This library is included by default so the `Dom` module will always be available in Melange projects. - Disable warning 61 (`unboxable-type-in-prim-decl`) for externals generated by Melange ([melange-re/melange#641](melange-re/melange#641), [melange-re/melange#643](melange-re/melange#643)) - Add `--rectypes` ([melange-re/melange#644](melange-re/melange#644)) to enable [recursive types](https://v2.ocaml.org/releases/5.0/htmlman/types.html#sss:typexpr-aliased-recursive) - [melange.ppx]: Deprecate `bs.*` attributes in favor of `mel.*` ([melange-re/melange#566](melange-re/melange#566), [melange-re/melange#662](melange-re/melange#662), [melange-re/melange#663](melange-re/melange#663)) - [melange]: Fix field access code generation when `open`in inline functor applications ([melange-re/melange#661](melange-re/melange#661), [melange-re/melange#664](melange-re/melange#664)) - [melange]: Upgrade the OCaml typechecker version to 5.1 ([melange-re/melange#668](melange-re/melange#668)) - [melange.ppx]: Deprecate `[@@mel.val]` and suggest its removal. This attribute is redundant and unnecessary ([melange-re/melange#675](melange-re/melange#675), [melange-re/melange#678](melange-re/melange#678)) - [melange]: remove old, unused CLI flags: `-bs-ns`, `-bs-cmi`, `-bs-cmj`, `-bs-no-builtin-ppx`, `-bs-super-errors` ([melange-re/melange#686](melange-re/melange#686)). - [melange]: generate correct code for types with the `option` shape ([melange-re/melange#700](melange-re/melange#700)). - [melange]: stop exporting `$$default` in the generated JavaScript when using ES6 default exports `let default = ..` ([melange-re/melange#708](melange-re/melange#708)). - [melange]: allow exporting invalid OCaml identifiers in the resulting JavaScript with `@mel.as` ([melange-re/melange#714](melange-re/melange#714), fixes [melange-re/melange#713](melange-re/melange#713)). - [melange]: Allow using `@mel.as` in external declarations without explicitly annotating `@mel.{string,int}` ([melange-re/melange#722](melange-re/melange#722), fixes [melange-re/melange#578](melange-re/melange#578)). - [melange]: Allow using `@mel.unwrap` in external declarations with `@mel.obj` ([melange-re/melange#724](melange-re/melange#724), fixes [melange-re/melange#679](melange-re/melange#679)). - [melange]: Support renaming fields in inline records / record extensions with `@mel.as` ([melange-re/melange#732](melange-re/melange#732), fixes [melange-re/melange#730](melange-re/melange#730)).

anmonteiro added 10 commits May 18, 2023 17:40

[melange.ppx]: move pipe-first to melange.ppx

c4ad9f5

wip

d5d4a69

fix a few tests

c340ac2

ppx doesn't need to depend on melange.ppxlib

8061d7a

chore: convert derivers

8a619a0

Port class_type / core_type mappers

74fe5bf

port label_declaration mapper

2d770c4

port entire ppx / refactor ext

c684ef3

add back --as-ppx

23b07ea

wip

728996a

anmonteiro changed the title ~~[melange.ppx]: move pipe-first to melange.ppx~~ [melange.ppx]: move the entire PPX frontend to melange.ppx May 20, 2023

anmonteiro added 6 commits May 20, 2023 16:55

cleanup / get everything compiling

187cbff

fix bs.deriving abstract test

b547e5f

more cleanup, fix more tests

8d18d76

fix tests

f74292f

fix: compile on 4.13

dd46e7a

pin reason-react for template

c6d58ca

anmonteiro force-pushed the anmonteiro/pipe-to-ppx branch from d3c46a2 to c6d58ca Compare May 21, 2023 06:26

anmonteiro added 6 commits May 20, 2023 23:55

Add change log entry

36043b1

require bs.deriving abstract + bs.optional to be explicitly option

56dcc87

fix deriving test

1e0000e

update flake.lock, fix one last test

49e8a1f

fix opam build

5ac728f

ppx: don't error for bs.attributes, issue alerts instead

619376c

jchavarri reviewed May 22, 2023

View reviewed changes

anmonteiro added 5 commits May 22, 2023 13:50

make redundant bs string a warning

c641243

clean up unused errors

8fe12a5

Add -alert to the PPX and use the alerting system

b9384cc

promote tests``

25fcb98

dont override dune

2238f3e

anmonteiro added 7 commits May 24, 2023 17:37

wip: better error message, update flake.lock

40aa9ed

move makeWrapper to nativeBuildInputs

5856bcf

Merge remote-tracking branch 'origin/main' into anmonteiro/pipe-to-ppx

abef3f0

update flake

2708af4

fix(test): make legacy-ounit-cmd test output compatible with 5.1

2e8aeba

Merge remote-tracking branch 'origin/main' into anmonteiro/pipe-to-ppx

e131217

update flake

47c95b3

anmonteiro mentioned this pull request May 30, 2023

melange ppx: fatal error when parsing %raw with callback #590

Merged

anmonteiro added 3 commits May 30, 2023 11:38

Merge remote-tracking branch 'origin/main' into anmonteiro/pipe-to-ppx

4e993ce

Merge remote-tracking branch 'origin/main' into anmonteiro/pipe-to-ppx

3d7fce3

Merge branch 'main' into anmonteiro/pipe-to-ppx

c8ddc79

anmonteiro merged commit 2202fcb into main Jun 1, 2023

anmonteiro deleted the anmonteiro/pipe-to-ppx branch June 1, 2023 17:49

anmonteiro added a commit that referenced this pull request Jun 1, 2023

add changelog for #583

9158053

anmonteiro mentioned this pull request Jun 4, 2023

playground: make jsoo_main compile #538

Merged

6 tasks

jchavarri mentioned this pull request Jun 5, 2023

Update docs to reflect breaking changes in bs.deriving and bs.optional melange-re/melange-re.github.io#75

Closed

anmonteiro mentioned this pull request Sep 14, 2023

[new release] melange (2 packages) (2.0.0) ocaml/opam-repository#24430

Merged

jchavarri mentioned this pull request Oct 24, 2023

melange: remove ppx flag from merlin ocaml/dune#8992

Merged

This was referenced Dec 18, 2023

ppx: show strange quoted strings transform #863

Merged

fix: move the UTF8 transform to the compiler core #995

Merged

jchavarri mentioned this pull request Jan 23, 2024

feat: unicode strings as quoted extensions #1035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

[melange.ppx]: move the entire PPX frontend to melange.ppx#583

[melange.ppx]: move the entire PPX frontend to melange.ppx#583
anmonteiro merged 37 commits intomainfrom
anmonteiro/pipe-to-ppx

anmonteiro commented May 19, 2023 •

edited

Loading

Uh oh!

jchavarri left a comment

Uh oh!

jchavarri May 22, 2023

Uh oh!

anmonteiro May 22, 2023

Uh oh!

jchavarri May 22, 2023

Uh oh!

anmonteiro May 22, 2023

Uh oh!

jchavarri May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// Generated by Melange
		/* This output is empty. Its source's type definitions, externals and/or unused code got optimized away. */

Uh oh!

Comments

Conversation

anmonteiro commented May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jchavarri left a comment

Choose a reason for hiding this comment

Uh oh!

jchavarri May 22, 2023

Choose a reason for hiding this comment

Uh oh!

anmonteiro May 22, 2023

Choose a reason for hiding this comment

Uh oh!

jchavarri May 22, 2023

Choose a reason for hiding this comment

Uh oh!

anmonteiro May 22, 2023

Choose a reason for hiding this comment

Uh oh!

jchavarri May 22, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anmonteiro commented May 19, 2023 •

edited

Loading