Skip to content

NumberFormat/PluralRules updates #16923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
queengooborg merged 12 commits into from
Jul 25, 2022
Merged

NumberFormat/PluralRules updates #16923

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5beaf24
NumberFormat/PluralRules updates
hamishwillee Jul 12, 2022
714e250
number_param_string_is_decimal subfeature
hamishwillee Jul 18, 2022
08e99da
options_useGrouping_parameter - options added
hamishwillee Jul 18, 2022
e287cac
resolvedOptions() may return incompatible values
hamishwillee Jul 18, 2022
af8af96
Update javascript/builtins/intl/NumberFormat.json
hamishwillee Jul 18, 2022
9e9867f
Fix build errors
hamishwillee Jul 18, 2022
10bcba5
Apply suggestions from code review
hamishwillee Jul 19, 2022
4383b15
Add options_useGrouping_parameter.string_values subfeature
hamishwillee Jul 19, 2022
b42cf48
Fix names of features to pass linter
hamishwillee Jul 19, 2022
d05a7d3
Add result_useGrouping_property property
hamishwillee Jul 19, 2022
3c26f39
Update javascript/builtins/intl/NumberFormat.json
hamishwillee Jul 25, 2022
b307181
Add back options_useGrouping_parameter description
hamishwillee Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 139 additions & 14 deletions javascript/builtins/intl/NumberFormat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,40 +571,88 @@
},
"options_useGrouping_parameter": {
"__compat": {
"description": "<code>options.useGrouping</code> parameter",
Copy link
Contributor

@queengooborg queengooborg Jul 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added back!

Copy link
Contributor Author

@hamishwillee hamishwillee Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry - no idea why I would have removed that.

"support": {
"chrome": {
"version_added": false
"version_added": "24"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
"version_added": "1.8"
},
"edge": {
"version_added": "12"
},
"edge": "mirror",
"firefox": {
"version_added": "preview"
"version_added": "29"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
"firefox_android": {
"version_added": "56"
},
"nodejs": {
"version_added": false
"ie": {
"version_added": "11"
},
"nodejs": [
{
"version_added": "13.0.0"
},
{
"version_added": "0.12.0",
"partial_implementation": true,
"notes": "Before version 13.0.0, only the locale data for <code>en-US</code> is available by default. When other locales are specified, the <code>NumberFormat</code> instance silently falls back to <code>en-US</code>. To make full ICU (locale) data available before version 13, see <a href='https://nodejs.org/docs/latest/api/intl.html#intl_options_for_building_node_js'>Node.js documentation on the <code>--with-intl</code> option</a> and how to provide the data."
}
],
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
"version_added": "10"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
},
"options_useGrouping_parameter-string_values": {
"__compat": {
"description": "<code>options.useGrouping</code> parameter accepts: <code>'always'</code>, <code>'auto'</code>, <code>'min2'</code> (in addition to: <code>true</code> and <code>false</code>)",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": false
},
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
}
},
Expand Down Expand Up @@ -653,6 +701,45 @@
"standard_track": true,
"deprecated": false
}
},
"number_parameter-string_decimal": {
"__compat": {
"description": "<code>number</code> param string value is decimal (not <code>Number</code>)",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
},
"formatRange": {
Expand All @@ -669,7 +756,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -709,7 +796,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -821,6 +908,44 @@
"standard_track": true,
"deprecated": false
}
},
"result_useGrouping_property": {
"__compat": {
"description": "The result <code>useGrouping</code> parameter may contain <code>'always'</code>, ode>'auto'</code>, <code>'min2'</code>, <code>true</code> and <code>false</code> (previous versions may only ntain <code>true</code> and <code>false</code>)",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": false
},
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
},
"supportedLocalesOf": {
Expand Down
2 changes: 1 addition & 1 deletion javascript/builtins/intl/PluralRules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
Expand Down