NumberFormat/PluralRules updates #16923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:js
This was referenced Jul 12, 2022
Contributor
Author
|
@queengooborg Does adding support for preview count as a supported platform? I ask because if this feature is supported in Chrome "real versions" and FF preview it is still really only widely available in one platform. I ask because it wants me to change this to not experimental when I consider it still to be. |
hamishwillee
commented
Jul 18, 2022
hamishwillee
commented
Jul 18, 2022
hamishwillee
commented
Jul 18, 2022
hamishwillee
commented
Jul 18, 2022
hamishwillee
force-pushed
the
intl_numberformat
branch
from
480d8fa to
9e9867f
Compare
hamishwillee
commented
Jul 19, 2022
Contributor
Author
|
@queengooborg Thanks. More advice required on this please. |
hamishwillee
commented
Jul 19, 2022
hamishwillee
commented
Jul 19, 2022
hamishwillee
commented
Jul 19, 2022
Contributor
Author
|
@queengooborg Should be good to review "in full" now. |
queengooborg
requested changes
Jul 23, 2022
| }, | ||
| "options_useGrouping_parameter": { | ||
| "__compat": { | ||
| "description": "<code>options.useGrouping</code> parameter", |
Contributor
There was a problem hiding this comment.
This should be added back!
Contributor
Author
There was a problem hiding this comment.
Done. Sorry - no idea why I would have removed that.
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF supports a number of
Intl.NumberFormatitems in nightly from https://bugzilla.mozilla.org/show_bug.cgi?id=1648137This includes:
Intl.NumberFormat.format()- subfeaturenumber_param_string_is_decimalto reflect spec update that strings are treated as Decimal rather than Number - see https://github.com/tc39/proposal-intl-numberformat-v3#interpret-strings-as-decimals-ecma-402-334Intl.NumberFormat.formatRange()Intl.NumberFormat.formatRangeToParts()Intl.PluralRules.selectRange()