refactor(base): Remove unused beacons from BaseRoomInfo#6041
Merged
stefanceriu merged 1 commit intomatrix-org:mainfrom Jan 22, 2026
Merged
refactor(base): Remove unused beacons from BaseRoomInfo#6041stefanceriu merged 1 commit intomatrix-org:mainfrom
beacons from BaseRoomInfo#6041stefanceriu merged 1 commit intomatrix-org:mainfrom
Conversation
This field was added already unused in the initial PR matrix-org#3741 for live location sharing. The follow up live location PRs didn't make use of it either: - matrix-org#3771 - matrix-org#3794 - matrix-org#4025 Signed-off-by: Kévin Commaille <[email protected]>
Hywan
approved these changes
Jan 19, 2026
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
I think we should merge this PR. We can still revert it in case this field was necessary in the future.
Waiting on another review from @stefanceriu.
Member
|
I'm just waiting for an answer from the original creator, there's no rush here. |
Member
|
Guess it's been long enough 🚀 Thank your keeping an eye out, Kevin 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field was added already unused in the initial PR #3741 for live location sharing. By "unused" I mean that it is written to but never read.
The follow up live location PRs didn't make use of it either:
Note that it is not exposed in the public API so no one can use it outside of the crate.
Maybe ping @torrybr which added this field, to clarify what it was intended to be used for in the first place, or if it is still intended to be used but the feature hasn't been implemented yet?