sdk: basic support for sending location beacons#3771
Merged
jmartinesp merged 3 commits intomatrix-org:mainfrom Jul 29, 2024
Merged
sdk: basic support for sending location beacons#3771jmartinesp merged 3 commits intomatrix-org:mainfrom
jmartinesp merged 3 commits intomatrix-org:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3771 +/- ##
==========================================
+ Coverage 84.07% 84.08% +0.01%
==========================================
Files 259 259
Lines 27080 27087 +7
==========================================
+ Hits 22767 22776 +9
+ Misses 4313 4311 -2 ☔ View full report in Codecov by Sentry. |
torrybr
force-pushed
the
feat/send-beacon
branch
from
24c7f2c to
ab6d039
Compare
torrybr
force-pushed
the
feat/send-beacon
branch
from
3cb0bea to
dd25293
Compare
jmartinesp
approved these changes
Jul 29, 2024
Contributor
jmartinesp
left a comment
jmartinesp
left a comment
There was a problem hiding this comment.
LGTM! Thanks for moving the tests to a new file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces basic functionality for sending beacons associated with a live location share, as outlined in the matrix-org/matrix-spec-proposals#3489. This foundational support allows users to send their live location beacon.
Key Changes
send_location_beacon: simple support for sending abeaconmessage event with relatedbeacon_infoevent id.These changes were adapted from a previous MR discussion, available for reference here.
Follow-up
This does not save any
beaconmessage events with its associatedbeacon_info. This MR simply introducesbeaconsending support with the intention of follow on MRs to build on this basic functionality.Signed-off-by: