This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix device selection in pre-join screen for Element Call video rooms#9321
Merged
Fix device selection in pre-join screen for Element Call video rooms#9321
Conversation
dbkr
added
the
T-Defect
robintown
reviewed
Sep 27, 2022
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
The device selection buttons are still configured to show fallback labels when they don't know the actual labels. Would you be able to slip the removal of that in as well?
Member
Author
|
Yeah, although I think this will still happen, so I think we need to do more to fix this: I think by getting and holding on to a stream while we call enumerateDevices because FF only gives you names if you have an active stream or persistent permission. I was going to do this in a separate PR, although I guess this will be broken if the device names are blank, so perhaps we should bundle it into this one. |
This means we can remove the device fallback labels.
Member
Author
|
ARGH. This doesn't work in Safari. Of course it doesn't work in Safari. |
robintown
reviewed
Sep 29, 2022
robintown
approved these changes
Sep 30, 2022
robintown
suggested changes
Sep 30, 2022
robintown
approved these changes
Sep 30, 2022
odelcroi
added a commit
to tchapgouv/tchap-web-v4
that referenced
this pull request
Oct 5, 2022
* Device manager - select all devices ([\#9330](matrix-org/matrix-react-sdk#9330)). Contributed by @kerryarchibald. * New group call experience: Call tiles ([\#9332](matrix-org/matrix-react-sdk#9332)). * Add Shift key to FormatQuote keyboard shortcut ([\#9298](matrix-org/matrix-react-sdk#9298)). Contributed by @owi92. * Device manager - sign out of multiple sessions ([\#9325](matrix-org/matrix-react-sdk#9325)). Contributed by @kerryarchibald. * Display push toggle for web sessions (MSC3890) ([\#9327](matrix-org/matrix-react-sdk#9327)). * Add device notifications enabled switch ([\#9324](matrix-org/matrix-react-sdk#9324)). * Implement push notification toggle in device detail ([\#9308](matrix-org/matrix-react-sdk#9308)). * New group call experience: Starting and ending calls ([\#9318](matrix-org/matrix-react-sdk#9318)). * New group call experience: Room header call buttons ([\#9311](matrix-org/matrix-react-sdk#9311)). * Make device ID copyable in device list ([\#9297](matrix-org/matrix-react-sdk#9297)). Contributed by @duxovni. * Use display name instead of user ID when rendering power events ([\#9295](matrix-org/matrix-react-sdk#9295)). * Read receipts for threads ([\#9239](matrix-org/matrix-react-sdk#9239)). Fixes #23191. * Fix device selection in pre-join screen for Element Call video rooms ([\#9321](matrix-org/matrix-react-sdk#9321)). Fixes #23331. * Don't render a 1px high room topic if the room topic is empty ([\#9317](matrix-org/matrix-react-sdk#9317)). Contributed by @Arnei. * Don't show feedback prompts when that UIFeature is disabled ([\#9305](matrix-org/matrix-react-sdk#9305)). Fixes #23327. * Fix soft crash around unknown room pills ([\#9301](matrix-org/matrix-react-sdk#9301)). Fixes matrix-org/element-web-rageshakes#15465. * Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](matrix-org/matrix-react-sdk#9302)). Fixes #23314. * Fix tile soft crash in ReplyInThreadButton ([\#9300](matrix-org/matrix-react-sdk#9300)). Fixes matrix-org/element-web-rageshakes#15493.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per element-hq/element-call#609
Also fix lying comment on getDevices() - it wasn't just for Electron at all - and make it a bit more descriptive.
Fixes element-hq/element-web#23331
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes