This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fixes around URL tooltips and in-app matrix.to link handling#9139
Merged
Fixes around URL tooltips and in-app matrix.to link handling#9139
Conversation
t3chguy
added
the
T-Task
t3chguy
changed the title
t3chguy
added
the
X-Release-Blocker
turt2live
reviewed
Aug 8, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
generally lgtm - I think the code does the correct thing, but have not manually tested
… t3chguy/url-tooltip-fixes
dbkr
approved these changes
Aug 9, 2022
…t3chguy/url-tooltip-fixes
kerryarchibald
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Add regression test for tooltipify exposing raw HTML * Handle m.to links involving children better * Comments * Fix mistaken assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#22953
Fixes element-hq/element-web#22970
This change is marked as an internal change (Task), so will not be included in the changelog.